Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4130 closed defect (fixed)

Write: paste don't work

Reported by: godiard Owned by: godiard
Priority: Urgent Milestone:
Component: Write Version: Unspecified
Severity: Unspecified Keywords: 13.1.0, regression, r?
Cc: garnacho, dsd, manuq Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Can't copy / paste in Write activity v 82

Attachments (1)

0001-Use-getter-to-get-a-Gtk.Clipboard.patch (932 bytes) - added by garnacho 8 years ago.
patch to fix Write issue

Download all attachments as: .zip

Change History (18)

comment:1 Changed 8 years ago by godiard

  • Priority changed from Unspecified by Maintainer to Urgent

comment:2 Changed 8 years ago by godiard

  • Keywords regression added

comment:3 Changed 8 years ago by godiard

  • Summary changed from Write: clipboard operations don't work to Write: paste don't work

Updated Summmary: With all the latest bits (gtk, pygobject abiword, write) copy is fixed but paste does not work yet.

comment:4 Changed 8 years ago by godiard

  • Cc garnacho added

With the new rpms to fix #4307 (set_with_data) Write do not paste, but show the following error in the log

(sugar-activity:4860): Gdk-CRITICAL **: gdk_display_get_default_screen: assertion `GDK_IS_DISPLAY (display)' failed

(sugar-activity:4860): Gtk-CRITICAL **: gtk_invisible_new_for_screen: assertion `GDK_IS_SCREEN (screen)' failed

(sugar-activity:4860): Gtk-CRITICAL **: gtk_widget_add_events: assertion `GTK_IS_WIDGET (widget)' failed

(sugar-activity:4860): Gdk-CRITICAL **: gdk_display_get_default_screen: assertion `GDK_IS_DISPLAY (display)' failed

(sugar-activity:4860): Gtk-CRITICAL **: gtk_invisible_new_for_screen: assertion `GDK_IS_SCREEN (screen)' failed

(sugar-activity:4860): Gtk-CRITICAL **: gtk_widget_add_events: assertion `GTK_IS_WIDGET (widget)' failed

(sugar-activity:4860): Gtk-CRITICAL **: gtk_selection_convert: assertion `GTK_IS_WIDGET (widget)' failed

Changed 8 years ago by garnacho

patch to fix Write issue

comment:5 Changed 8 years ago by garnacho

This patch fixes the Write issue, clipboards aren't meant to be newly created, so a getter must be used

comment:6 Changed 8 years ago by erikos

  • Keywords 13.1.0 r? added
clipboard = Gtk.Clipboard.get(Gdk.SELECTION_CLIPBOARD)

Will work as well.

comment:7 Changed 8 years ago by godiard

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in version 85

comment:8 follow-up: Changed 8 years ago by dsd

Installed Write-85 on top of 13.1.0 build 20, but copy/paste still doesn't work. Copy does create an icon in the clipboard tray, but paste doesn't seem to do anything. Testing with the edit toolbar each time. How can this be tested?

comment:9 Changed 8 years ago by dsd

  • Cc dsd added

comment:10 in reply to: ↑ 8 Changed 8 years ago by godiard

Replying to dsd:

Installed Write-85 on top of 13.1.0 build 20, but copy/paste still doesn't work. Copy does create an icon in the clipboard tray, but paste doesn't seem to do anything. Testing with the edit toolbar each time. How can this be tested?

Is strange, I see other problems supposedly solved, like the first clipboard item showing the palette when added to the frame, and the second catching the mouse. Are all the pieces needed to solve #4307 included in os20?

comment:11 Changed 8 years ago by dsd

The only pieces included in build 20 are the 2 packages noted on the ticket, pygobject and gtk3. Are the other pending bits needed before this can be tested?

comment:12 Changed 8 years ago by godiard

  • Cc manuq added

Manuq, Garnacho, can you confirm if we need something more than the new pygobject and gtk3 packages to test this?

comment:13 follow-up: Changed 8 years ago by dsd

It seems to work after updating to the latest sugar/sugar-toolkit-gtk3 releases. I had assumed that this wouldn't influence this my test case, but apparently it does.

comment:14 in reply to: ↑ 13 Changed 8 years ago by garycmartin

Replying to dsd:

It seems to work after updating to the latest sugar/sugar-toolkit-gtk3 releases. I had assumed that this wouldn't influence this my test case, but apparently it does.

I've just re-tested with 13.1.0 build 20, a local fresh builds of mainline shell/toolkit/artwork, and Write-85 and pasting into Write is now working. Write-85, I think, was the piece of the jigsaw I needed to get this actually working in build 20.

comment:15 Changed 8 years ago by godiard

  • Resolution fixed deleted
  • Status changed from closed to reopened

A pending issue I have found is the paste of images. (Try copy from Paint and paste in Write). The method save is not available in GdkPixbuf anymore.

A fix was pushed as 7eeb53f79a1fd247825df4072fb48e8a612323e3, we need package and include a new version.

comment:16 Changed 8 years ago by godiard

  • Resolution set to fixed
  • Status changed from reopened to closed

Included in version 86

comment:17 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.