Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4131 closed defect (fixed)

Terminal: do not saves/restore session

Reported by: godiard Owned by: godiard
Priority: Urgent Milestone:
Component: Terminal Version: Unspecified
Severity: Critical Keywords: regression
Cc: godiard, tonyforster Distribution/OS: OLPC
Bug Status: Assigned

Description

When the terminal starts, do not have the last tabs opened and the content in the tabs is not available.

Probably is related with the commit 5bff52765091225a1ef4095812064337c0b48dd3 and the get_text() method not available in the gi bindings.

Upstream bug https://bugzilla.gnome.org/show_bug.cgi?id=676999

Attachments (5)

0001-Get-back-a-working-activity-history-SL-4131.patch (4.8 KB) - added by erikos 8 years ago.
Get back a working activity history
0001-Move-definition-of-VteCharAttributes-up-676999.patch (1.4 KB) - added by erikos 8 years ago.
vte patch
test_vte_get_text.py (1.3 KB) - added by godiard 8 years ago.
Python test case
0001-Add-support-for-caller-allocated-GArray-out-argument.patch (4.9 KB) - added by godiard 8 years ago.
Backported patch for pygobject
error.log (14.3 KB) - added by godiard 8 years ago.
Log of the crashed test case

Download all attachments as: .zip

Change History (20)

comment:1 Changed 8 years ago by godiard

  • Cc godiard added

comment:2 Changed 8 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Distribution/OS changed from Unspecified to OLPC
  • Priority changed from Unspecified by Maintainer to Urgent
  • Severity changed from Unspecified to Critical

This one is really important, as we loose major functionality. Raffael, can you have a look at this one?

Changed 8 years ago by erikos

Get back a working activity history

comment:3 follow-up: Changed 8 years ago by erikos

I advanced a bit on the upstream introspection issue. I could build vte here and with the above Terminal patch use the get_text method and had the tabs restored.

comment:4 Changed 8 years ago by godiard

  • Keywords regression added

comment:5 in reply to: ↑ 3 ; follow-up: Changed 8 years ago by godiard

Replying to erikos:

I advanced a bit on the upstream introspection issue. I could build vte here and with the above Terminal patch use the get_text method and had the tabs restored.

There are a upstream bug?

comment:6 in reply to: ↑ 5 Changed 8 years ago by erikos

Replying to godiard:

Replying to erikos:

I advanced a bit on the upstream introspection issue. I could build vte here and with the above Terminal patch use the get_text method and had the tabs restored.

There are a upstream bug?

Is in the ticket description :) https://bugzilla.gnome.org/show_bug.cgi?id=676999

comment:7 Changed 8 years ago by tonyforster

  • Cc tonyforster added

See #4243 for another case of a journal entry not resuming

comment:8 Changed 8 years ago by erikos

Pushed the vte fix: http://git.gnome.org/browse/vte/commit/?h=vte-0-34&id=2ba27999b537300f4beb92ca27830fbd4197740e

Now we need to get this into a release. Currently no vte-0-34 release is planned. We could include the patch into the F18 rpm probably.

Changed 8 years ago by erikos

vte patch

comment:9 Changed 8 years ago by godiard

Another upstream ticket has been opened https://bugzilla.gnome.org/show_bug.cgi?id=690003

comment:10 Changed 8 years ago by godiard

A bug was found in pyobject, we can't use a caller-allocated GArray in python.

Already discussed with pitti and filled https://bugzilla.gnome.org/show_bug.cgi?id=690041

comment:11 Changed 8 years ago by godiard

The ticket #690041 was fixed for the 3.7.3 branch.

I have tried backport it to 3.4.3, and run the test (with the fix for #690003 too) but i have a crash. I don't know if we need other fixes in 3.7.3 branch.

Attached are test case, the backported patch and trace log

Changed 8 years ago by godiard

Python test case

Changed 8 years ago by godiard

Backported patch for pygobject

Changed 8 years ago by godiard

Log of the crashed test case

comment:12 Changed 8 years ago by godiard

comment:13 Changed 8 years ago by erikos

  • Owner changed from RafaelOrtiz to godiard
  • Status changed from new to assigned

This one is tricky, we are currently blocked on https://bugzilla.gnome.org/show_bug.cgi?id=690610

I will get the ticket to you Gonzalo as you have been the last one investigating.

comment:14 Changed 8 years ago by godiard

  • Resolution set to fixed
  • Status changed from assigned to closed

Finally, upstream issues are solved, and a modified version of Simon patch works ok.

Included on version 42, patch sent to dfrancis to be pushed to git.

comment:15 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.