Context Navigation

← Previous Ticket
Next Ticket →

#4131 closed defect (fixed)

Terminal: do not saves/restore session

Reported by:	godiard	Owned by:	godiard
Priority:	Urgent	Milestone:
Component:	Terminal	Version:	Unspecified
Severity:	Critical	Keywords:	regression
Cc:	godiard, tonyforster	Distribution/OS:	OLPC
Bug Status:	Assigned

Description

When the terminal starts, do not have the last tabs opened and the content in the tabs is not available.

Probably is related with the commit 5bff52765091225a1ef4095812064337c0b48dd3 and the get_text() method not available in the gi bindings.

Upstream bug https://bugzilla.gnome.org/show_bug.cgi?id=676999

Attachments (5)

0001-Get-back-a-working-activity-history-SL-4131.patch (4.8 KB) - added by erikos 10 years ago.: Get back a working activity history
0001-Move-definition-of-VteCharAttributes-up-676999.patch (1.4 KB) - added by erikos 10 years ago.: vte patch
test_vte_get_text.py (1.3 KB) - added by godiard 10 years ago.: Python test case
0001-Add-support-for-caller-allocated-GArray-out-argument.patch (4.9 KB) - added by godiard 10 years ago.: Backported patch for pygobject
error.log (14.3 KB) - added by godiard 10 years ago.: Log of the crashed test case

Download all attachments as: .zip

Change History (20)

comment:1 Changed 10 years ago by godiard

Cc godiard added

comment:2 Changed 10 years ago by erikos

Bug Status changed from Unconfirmed to Assigned
Distribution/OS changed from Unspecified to OLPC
Priority changed from Unspecified by Maintainer to Urgent
Severity changed from Unspecified to Critical

This one is really important, as we loose major functionality. Raffael, can you have a look at this one?

Changed 10 years ago by erikos

Attachment 0001-Get-back-a-working-activity-history-SL-4131.patch added

Get back a working activity history

comment:3 follow-up: ↓ 5 Changed 10 years ago by erikos

I advanced a bit on the upstream introspection issue. I could build vte here and with the above Terminal patch use the get_text method and had the tabs restored.

comment:4 Changed 10 years ago by godiard

Keywords regression added

comment:5 in reply to: ↑ 3 ; follow-up: ↓ 6 Changed 10 years ago by godiard

Replying to erikos:

I advanced a bit on the upstream introspection issue. I could build vte here and with the above Terminal patch use the get_text method and had the tabs restored.

There are a upstream bug?

comment:6 in reply to: ↑ 5 Changed 10 years ago by erikos

Replying to godiard:

Replying to erikos:

I advanced a bit on the upstream introspection issue. I could build vte here and with the above Terminal patch use the get_text method and had the tabs restored.

There are a upstream bug?

Is in the ticket description :) https://bugzilla.gnome.org/show_bug.cgi?id=676999

comment:7 Changed 10 years ago by tonyforster

Cc tonyforster added

See #4243 for another case of a journal entry not resuming

comment:8 Changed 10 years ago by erikos

Pushed the vte fix: http://git.gnome.org/browse/vte/commit/?h=vte-0-34&id=2ba27999b537300f4beb92ca27830fbd4197740e

Now we need to get this into a release. Currently no vte-0-34 release is planned. We could include the patch into the F18 rpm probably.

Changed 10 years ago by erikos

Attachment 0001-Move-definition-of-VteCharAttributes-up-676999.patch added

vte patch

comment:9 Changed 10 years ago by godiard

Another upstream ticket has been opened https://bugzilla.gnome.org/show_bug.cgi?id=690003

comment:10 Changed 10 years ago by godiard

A bug was found in pyobject, we can't use a caller-allocated GArray in python.

Already discussed with pitti and filled https://bugzilla.gnome.org/show_bug.cgi?id=690041

comment:11 Changed 10 years ago by godiard

The ticket #690041 was fixed for the 3.7.3 branch.

I have tried backport it to 3.4.3, and run the test (with the fix for #690003 too) but i have a crash. I don't know if we need other fixes in 3.7.3 branch.

Attached are test case, the backported patch and trace log