Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#3925 closed defect (fixed)

Layout code in Home View does not respect an Alert

Reported by: erikos Owned by: erikos
Priority: Normal Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Unspecified Keywords: r+, regression
Cc: humitos Distribution/OS: Fedora
Bug Status: Assigned

Description

  • open an Alert in the Home View (e.g. use the register option in the owner icon Palette)

---> the Owner icon stays at the same position but the ring icons shift down by the height of the alert.

Attachments (2)

0001-Recalculate-the-position-of-the-owner-SL-3925.patch (1.1 KB) - added by humitos 7 years ago.
An approach to this fix. The value is hardcoded and that doesn't look good :)
0001-Recalculate-the-position-of-the-icons-SL-3925.patch (1.8 KB) - added by humitos 7 years ago.
Leave the icons at the same place as erikos said. This patch just works for the RingLayout

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by erikos

see #3827 for inspiration.

comment:2 Changed 7 years ago by godiard

  • Priority changed from Unspecified by Maintainer to Normal

comment:3 Changed 7 years ago by humitos

  • Cc humitos added
  • Keywords r? added

I found the problem here:

That line removes the allocation.y value to the y position from where we are going to draw the buddy. So, with or without an Alert message this result will be always the same and the y position of the it will be the same.

We should remove just the height of the main toolbar. A patch with the hardcoded size value is attached to see the difference. It doesn't look good, but it's an approach.

Changed 7 years ago by humitos

An approach to this fix. The value is hardcoded and that doesn't look good :)

comment:4 Changed 7 years ago by erikos

  • Keywords r- added; r? removed

So there are two approaches here:

a) when the Alert appears, shift down all the icons in the Home View (owner icon to activity icons)

b) when the Alert appears, leave all icons at the same place

In the old shell we did do (b). So, I think preferred is to keep that behaviour if not too hard to do.

comment:5 Changed 7 years ago by erikos

  • Keywords regression added

Changed 7 years ago by humitos

Leave the icons at the same place as erikos said. This patch just works for the RingLayout

comment:6 Changed 7 years ago by godiard

  • Keywords r? added; r- removed

comment:7 Changed 7 years ago by manuq

  • Keywords r- added; r? removed

I think we need to investigate a more general approach.

comment:8 follow-up: Changed 7 years ago by godiard

Manuq, Can you explain a little more what you don't like about the solution proposed by humitos?

comment:9 in reply to: ↑ 8 Changed 7 years ago by manuq

  • Keywords r+ added; r- removed

Replying to godiard:

Manuq, Can you explain a little more what you don't like about the solution proposed by humitos?

I took another look and I think humitos solution is the right one. In the owner icon allocation we do the same adjustments, and is OK to calculate the spiral using the total screen height (allocation.height + allocation.y).

comment:10 Changed 7 years ago by erikos

  • Resolution set to fixed
  • Status changed from new to closed

Great, pushed the patch with small adjustments to the description and the in code comment. Pushed to the master and sucrose-0.98 branch.

comment:11 Changed 6 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.