#3924 closed defect (fixed)
Read search support is broken
Reported by: | greenfeld | Owned by: | godiard |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | |
Component: | Read | Version: | Unspecified |
Severity: | Unspecified | Keywords: | olpc-test-passed |
Cc: | Distribution/OS: | OLPC | |
Bug Status: | Unconfirmed |
Description
Read-101's search support is broken in pretty much every format.
With text files I see the following when the forward search button is pressed:
Traceback (most recent call last): File "/home/olpc/Activities/Read.activity/readtoolbar.py", line 141, in _find_next_cb self._search_find_first() File "/home/olpc/Activities/Read.activity/readtoolbar.py", line 91, in _search_find_first self._view.setup_find_job(text, self._find_updated_cb) File "/home/olpc/Activities/Read.activity/textadapter.py", line 321, in setup_find_job text=text, case_sensitive=False) File "/home/olpc/Activities/Read.activity/textadapter.py", line 401, in __init__ Gtk.gdk.threads_init() File "/usr/lib/python2.7/site-packages/gi/module.py", line 243, in __getattr__ return getattr(self._introspection_module, name) File "/usr/lib/python2.7/site-packages/gi/module.py", line 105, in __getattr__ self.__name__, name)) AttributeError: 'gi.repository.Gtk' object has no attribute 'gdk'
With EPUB files I do not see anything logged, but nothing gets searched for either (or potentially previous searches are used).
With PDF files I see:
Traceback (most recent call last): File "/home/olpc/Activities/Read.activity/readtoolbar.py", line 131, in _find_updated_cb self._view.find_changed(job, page) File "/home/olpc/Activities/Read.activity/evinceadapter.py", line 318, in find_changed self._view.find_changed(job, page) AttributeError: 'View' object has no attribute 'find_changed'
Ideally we should start searching for text when the forward/back buttons are pressed, starting from the last match of an item (if previously entered) or relative to the current shown location.
Tested on 12.1.0 os21.
Change History (3)
comment:1 Changed 11 years ago by godiard
- Keywords olpc-test-pending added
- Milestone changed from Unspecified by Release Team to 0.98
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 11 years ago by greenfeld
- Keywords olpc-test-passed added; olpc-test-pending removed
Search worked in epub, PDF, and text files with 13.1.0 os7 + Read-104.
I also got the table of contents working with a PDF file with a flat TOC structure (not nested). The nested PDF file which could not be paged-accessed via the TOC browser also could not be searched.
I do not know why yet (could be evince bug/respecting DRM-style flags/original PDF has incorrect code/etc.).
Test in version 102