#3827 closed defect (fixed)
Home View: owner icon/activity icon not drawn correctly when rotating the screen
| Reported by: | erikos | Owned by: | erikos |
|---|---|---|---|
| Priority: | Unspecified by Maintainer | Milestone: | |
| Component: | Sugar | Version: | 0.97.x |
| Severity: | Critical | Keywords: | r+, olpc-test-passed |
| Cc: | Distribution/OS: | OLPC | |
| Bug Status: | Resolved |
Description
Attachments (2)
Change History (8)
comment:1 Changed 11 years ago by erikos
Changed 11 years ago by garycmartin
comment:2 Changed 11 years ago by erikos
- Keywords r? added; nohippo removed
In the HomeWindow we listen to the size-changed signal and resize the window in that case. This will be triggered by the ViewContainer and the ViewLayout. In those cases we have to recreate the grid with the new dimensions.
Attached is a patch that does fix the issue.
comment:3 Changed 11 years ago by manuq
Yes, this fixes the central buddy icon allocation, and patch looks good. Please make it in.
comment:4 Changed 11 years ago by erikos
- Bug Status changed from Unconfirmed to Resolved
- Keywords r+ olpc-test-pending added; r? removed
- Resolution set to fixed
- Status changed from new to closed
comment:5 Changed 11 years ago by greenfeld
- Keywords olpc-test-passed added; olpc-test-pending removed
Rotation works in the home view and keeps all networks in the network view in OLPC 13.1.0 os8.
Note: See
TracTickets for help on using
tickets.
Actually, this is not a direct issue with the nohippo code. We had the same issue already before.
When the screen is rotated the new orientation is not taken into account when calculating the positions of the icons. The positioning of the icons in the layout is based on the screen dimensions. When the screen is rotated we do not re-calculate the positions. An easy way to see this in an old build is:
---> look at the icons
---> look at the icons
If you have enough icons in the Neighborhood View, you will see that there are more icons in the landscape mode than in the portrait mode, the positions have just been calculated once with the width/height of the landscape mode.