Opened 7 years ago

Closed 6 years ago

#3923 closed defect (wontfix)

Style notebook tabs

Reported by: manuq Owned by: danielfrancis
Priority: Low Milestone: Unspecified
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords: 13.1.0
Cc: erikos, danielfrancis Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description (last modified by manuq)

The GTK2 notebook tabs are a) confusing because the coloring of the active tab, the others and the rest of the space has very similar tones of grey and b) very thin, hard to click and not suitable for touch.

We solved this for the tabs of Browse after switching the activity to GTK+3. Now is time to generalize this for all the notebooks.

  • use same style as in Browse GTK+3 (active tab with toolbar background color)
  • get the same toolbar height for tabs with and without icons
  • buttons in active tab: use the same styling than toolbuttons for hovering and tap/click highlight
  • buttons in inactive tabs: also set styling for hovering and tap/click highlight

For the first item, Daniel Francis provided a patch to the mailing list.

Attachments (1)

0001-Set-padding-for-labels-in-Notebook-Tabs-SL-3923.patch (877 bytes) - added by danielfrancis 7 years ago.
Attaching the patch for the second point.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 7 years ago by manuq

  • Description modified (diff)

comment:2 Changed 7 years ago by danielfrancis

  • Cc danielfrancis added

comment:3 Changed 7 years ago by manuq

First item done with Daniel's patch, pushed as bf7fe386 .

comment:4 follow-up: Changed 7 years ago by danielfrancis

  • Bug Status changed from Unconfirmed to Assigned
  • Owner changed from manuq to danielfrancis
  • Status changed from new to assigned

Hi Manu,
I just tested and the second item can be already ticked. At Terminal, without the close button the tabs have the same height.

comment:5 in reply to: ↑ 4 Changed 7 years ago by manuq

Hi Dani,

Replying to danielfrancis:

Hi Manu,
I just tested and the second item can be already ticked. At Terminal, without the close button the tabs have the same height.

Yes for Terminal and Browse, which have a + button that makes the height the same. But not for all the notebooks.

Changed 7 years ago by danielfrancis

Attaching the patch for the second point.

comment:6 Changed 7 years ago by danielfrancis

I attached the patch for the seccond point. I did it throught setting paddings for the labels.

comment:7 Changed 7 years ago by godiard

  • Priority changed from Unspecified by Maintainer to Low

comment:8 Changed 7 years ago by danielfrancis

Manu, Can you review the patch I attached some time ago? I wouldn't like to make other patches related to this ticket if there's a patch pending.

comment:9 Changed 7 years ago by manuq

  • Resolution set to fixed
  • Status changed from assigned to closed

This was pushed a while ago as bf7fe386 .

comment:10 Changed 7 years ago by danielfrancis

  • Resolution fixed deleted
  • Status changed from closed to reopened

That was the first item of the ticket description,
Second item, height for tabs was not pushed and the patch is attached.
And there are other patches missing (see the ticket description).

Reopening.

comment:11 Changed 6 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:12 Changed 6 years ago by dnarvaez

  • Milestone changed from 0.98 to Unspecified

comment:13 Changed 6 years ago by dnarvaez

  • Bug Status changed from Assigned to Unconfirmed

comment:14 Changed 6 years ago by dnarvaez

Daniel, what is the status of this? If there is a patch to land can you please submit a pull request?

comment:15 Changed 6 years ago by danielfrancis

The old not reviewed patch will not be necessary with this commit:
https://github.com/sugarlabs/sugar-artwork/commit/6932e87d68816f449b84e9d42c3420fc7dc8f49d
I think buttons in active and inactive tabs are not styled yet. I can check this and/or make a patch in this week and submit a pull request.

comment:16 Changed 6 years ago by manuq

Hey danielfrancis,

Can you tell what are you missing from the style in tabs? I think they are in decent state.

The only thing I would like to see, is move the subclass of Gtk.Notebook that we have in Browse and Terminal to the toolkit. But that will have to wait the freeze.

comment:17 Changed 6 years ago by dnarvaez

  • Resolution set to wontfix
  • Status changed from reopened to closed

Per manuq review on the pull request. As he requested here please open a separate ticket if there are bits of the styling that should be fixed.

Note: See TracTickets for help on using tickets.