Visual representation of clipboard is not working (the copy/paste shortcut is)

[erikos]

seen in the latest 13.1.0 build, Sugar version 0.97.3

[tonyforster]

OS2
Copy and paste are working but the clip item does not appear in the left frame

[tonyforster]

still present in OS3

[erikos]

(checked in os5)

[godiard]

I was looking at this issue, I think we are affected by at least two upstream bugs related to clipboard management. This is a important usability feature, then we need solve it.

The first issue we need solve is replace

clipboard = Gtk.Clipboard()

by

clipboard = Gtk.Clipboard.get(Gdk.SELECTION_CLIPBOARD)

Is used in the following files:

src/jarabe/journal/palettes.py: clipboard = Gtk.Clipboard()
src/jarabe/frame/clipboardicon.py: x_clipboard = Gtk.Clipboard()
src/jarabe/frame/clipboard.py: gtk_clipboard = Gtk.Clipboard()
src/jarabe/frame/clipboardpanelwindow.py: self._clipboard = Gtk.Clipboard()

clipboardpanelwindow.py is related with this ticket (visual representation)

Doing this change we receive the signal "owner-changed" but are affected by this [1] upstream bug.

The other upstream bug affecting us is not related with the visual representation, but with the use of Clipboard.set_with_data [2], used in src/jarabe/journal/palettes.py and src/jarabe/frame/clipboardicon.py

[1] ​https://bugzilla.gnome.org/show_bug.cgi?id=678620
[2] ​https://bugzilla.gnome.org/show_bug.cgi?id=656312

[erikos]

Hmm, tricky. I looked for the 'wait_for_targets' issue. ​Here is what pygtk did in the override. That is how far I got.

[godiard]

The attached patch solves the visual representation part, (related to gtk bug 678620) and depends on the fix to [1]. With this patch, visual representation of the clipboard is available again.

The errors related to gtk+ bug 656312 will be addressed in another patch.

[1] ​https://bugzilla.gnome.org/show_bug.cgi?id=687942

[erikos]

Ok, I would like to see the gtk+ patch first landed at least in upstream master before we depend on it.

Carlos, can you help us upstreaming ​https://bugzilla.gnome.org/show_bug.cgi?id=687942 (either that this patch gets in or another fix is found)?

[godiard]

A different solution was included with two patches. Let me rework the sugar patch.

[erikos]

Yes, it landed in master so far, Martin said both patches can go into the 3.4 branch as well, he will do when he finds time. Will get into 3.4.3

[dsd]

These 2 patches:

• Fix marshalling of arrays of struct pointers to Python (Carlos Garnacho) (#678620)
• Fix Gdk.Atom to have a proper str() and repr() (Martin Pitt) (#678620)

are added here: ​http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=1261821

Please test and let me know. If it works I will package it "properly"

[godiard]

Updated version of sugar patch based in the backported pygobject patches

[godiard]

Simon, I have updated the patch based in the pygobject patches.

Daniel, Simon have permission to push the patches in the stable branch.

[dsd]

I'd still like you to test the package before I push it, please.

[godiard]

Replying to dsd:

I'd still like you to test the package before I push it, please.

Done.

• Install the rpm.
• Copy the modified files: cp palettes.py /usr/lib/python2.7/site-packages/jarabe/journal/ cp clipboard* /usr/lib/python2.7/site-packages/jarabe/frame/

• Restart sugar
• Open the terminal
• Select a text, and press Shift-Ctrl-C or use the copy button in the toolbar.

Result:

• A icon will appear in the frame at bottom left, the selected text is visible in the palette.

[dsd]

Gonzalo confirms he's run the test as well, succesfully. Thanks. pushed as pygobject3-3.4.2-3.fc18

[erikos]

I pushed the patches on the pygobject-3-4 branch.

[erikos]

Thanks a lot Gonzalo for your patch, I pushed that one now 9c7d980f8281f145b605710b7383b6fa8f1f58b4. It does not even break things without the latest pygobject3 from Daniel.

So, next is the second upstream clipboard issue...

[godiard]

Opened #4307 to follow set_with_data. Close this as fixed.

[dnarvaez]

Milestone 0.98 deleted