Opened 11 years ago

Closed 8 years ago

#3531 closed defect (fixed)

factorial() and fac() are redundant

Reported by: cjl Owned by: rwh
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Calculate Version: Unspecified
Severity: Unspecified Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

These "two" functions appear to be exactly the same mathematical concept, except one says "n" and the other says "x".

functions.py:244
factorial(n), return the factorial of n. Given by n * (n - 1) * (n - 2) * ...

functions.py:250
fac(x), return the factorial of x. Given by x * (x - 1) * (x - 2) * ...

Change History (2)

comment:1 Changed 11 years ago by cjl

  • Component changed from untriaged to Calculate
  • Owner set to rwh

comment:2 Changed 8 years ago by godiard

  • Resolution set to fixed
  • Status changed from new to closed

Fixed by ​https://github.com/godiard/sugarlabs-calculate/commit/6f44d720079586d84bce7e7a1a830aae023175cd

Note: See TracTickets for help on using tickets.