#1787 closed defect (fixed)
rebuild index on migration
| Reported by: | sascha_silbe | Owned by: | sascha_silbe |
|---|---|---|---|
| Priority: | Unspecified by Maintainer | Milestone: | |
| Component: | Sugar | Version: | Git as of bugdate |
| Severity: | Major | Keywords: | r+ |
| Cc: | alsroot | Distribution/OS: | Unspecified |
| Bug Status: | Assigned |
Description
Currently we force an index rescan on migration, but not a rebuild. Any entry that's already in the index will not be updated.
This patch fixes the migration logic to do a full index rebuild, thus actually migrating the index.
This issue should cause the version 1 -> version 2 update not to happen, but I currently don't have any version 1 data to verify against. I noticed it because it affects version 2 (mainline) -> version 3 (version support branch) migrations.
We'll probably want to backport this to 0.86 as well.
Attachments (1)
Change History (11)
comment:1 follow-up: ↓ 3 Changed 13 years ago by sascha_silbe
comment:2 Changed 13 years ago by alsroot
- Keywords r+ added; r? removed
comment:3 in reply to: ↑ 1 Changed 13 years ago by alsroot
Replying to sascha_silbe:
Come to think about it, we probably even want to introduce another version to force an index rebuild on systems that already missed it.
+1
just add new v4 to http://git.sugarlabs.org/projects/sugar-datastore/repos/mainline/blobs/master/README#line21
also, please fix it if something was missed
comment:4 Changed 13 years ago by sascha_silbe
- Cc alsroot added
- Keywords r? added; r+ removed
Updated patch with version bump to force index rebuild.
comment:5 Changed 13 years ago by alsroot
- Keywords r+ added; r? removed
r+ with using layoutmanager.CURRENT_LAYOUT_VERSION in datastore.py:65
comment:6 Changed 13 years ago by alsroot
r+, for last patch
comment:7 Changed 13 years ago by sascha_silbe
- Milestone changed from 0.88 to 0.86
comment:8 Changed 13 years ago by alsroot
- Resolution set to fixed
- Status changed from new to closed
comment:9 Changed 10 years ago by dnarvaez
- Component changed from sugar-datastore to Sugar
Come to think about it, we probably even want to introduce another version to force an index rebuild on systems that already missed it.