oversight in sugar.activity.activityfactory.ActivityCreationHandler._find_object_reply_handler()

[sascha_silbe]

Happened to me during testing the version support prototype; I am too lazy to reproduce it on the master branch right now but it should be obvious enough anyway.
sugar.activity.activityfactory.ActivityCreationHandler}} has been changed to use {{{sugar.datastore.datastore instead of interfacing with directly via D-Bus. A part of _find_object_reply_handler() was missed during the conversion:

    def _find_object_reply_handler(self, jobjects, count):
        if count > 0:
            if count > 1:
                logging.debug("Multiple objects has the same activity_id.")
            self._handle.object_id = jobjects[0]['uid']
        self._launch_activity()

jobjects is a list os DSObjects now, so we need to to use jobjects[0].metadata['uid'].

I guess the proper fix would be to pass data store object ids (uid resp. (tree_id, version_id)) instead of activity_ids.

[sascha_silbe]

I'm currently unable to figure out how to cause _find_object_reply_handler() to be called at all (and unlike I originally thought it doesn't just happen for duplicate {{{activity_id}}s), but the fix is straightforward.

[sascha_silbe]

fix oversight from direct D-Bus interfacing -> sugar.datastore.datastore conversion

[sascha_silbe]

Actually this only applies once #1609 is fixed.

[erikos]

Ok, moving that out to 0.90, as it is not a regression and discuss #1609.

[dnarvaez]

It's really unclear how to trigger this and what user visible issue it causes.