Opened 13 years ago
Closed 10 years ago
#1786 closed defect (incomplete)
oversight in sugar.activity.activityfactory.ActivityCreationHandler._find_object_reply_handler()
Reported by: | sascha_silbe | Owned by: | sascha_silbe |
---|---|---|---|
Priority: | Normal | Milestone: | Unspecified |
Component: | Sugar | Version: | Git as of bugdate |
Severity: | Unspecified | Keywords: | r? |
Cc: | Distribution/OS: | Unspecified | |
Bug Status: | Unconfirmed |
Description
Happened to me during testing the version support prototype; I am too lazy to reproduce it on the master branch right now but it should be obvious enough anyway.
sugar.activity.activityfactory.ActivityCreationHandler}} has been changed to use {{{sugar.datastore.datastore instead of interfacing with directly via D-Bus. A part of _find_object_reply_handler() was missed during the conversion:
def _find_object_reply_handler(self, jobjects, count): if count > 0: if count > 1: logging.debug("Multiple objects has the same activity_id.") self._handle.object_id = jobjects[0]['uid'] self._launch_activity()
jobjects is a list os DSObjects now, so we need to to use jobjects[0].metadata['uid'].
I guess the proper fix would be to pass data store object ids (uid resp. (tree_id, version_id)) instead of activity_ids.
Attachments (1)
Change History (9)
comment:1 Changed 13 years ago by sascha_silbe
- Keywords r? added
- Owner changed from erikos to sascha_silbe
- Status changed from new to accepted
- Summary changed from cannot launch activity if multiple data store entries have the same activity_id to oversight in sugar.activity.activityfactory.ActivityCreationHandler._find_object_reply_handler()
Changed 13 years ago by sascha_silbe
fix oversight from direct D-Bus interfacing -> sugar.datastore.datastore conversion
comment:2 Changed 13 years ago by erikos
- Priority changed from Unspecified by Maintainer to Immediate
comment:3 Changed 13 years ago by sascha_silbe
Actually this only applies once #1609 is fixed.
comment:4 Changed 13 years ago by erikos
- Milestone changed from 0.88 to 0.90
- Priority changed from Immediate to Normal
Ok, moving that out to 0.90, as it is not a regression and discuss #1609.
comment:5 Changed 10 years ago by dnarvaez
- Component changed from sugar-toolkit to Sugar
comment:6 Changed 10 years ago by dnarvaez
- Milestone changed from 0.90 to Unspecified
comment:7 Changed 10 years ago by dnarvaez
- Bug Status changed from New to Unconfirmed
comment:8 Changed 10 years ago by dnarvaez
- Resolution set to incomplete
- Status changed from accepted to closed
It's really unclear how to trigger this and what user visible issue it causes.
I'm currently unable to figure out how to cause _find_object_reply_handler() to be called at all (and unlike I originally thought it doesn't just happen for duplicate {{{activity_id}}s), but the fix is straightforward.