Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4357 closed defect (fixed)

Style GtkIconView to use the same background colour as the GtkTreeView

Reported by: danielfrancis Owned by: manuq
Priority: Normal Milestone:
Component: Sugar Version: 0.96.x
Severity: Minor Keywords:
Cc: garycmartin, manuq Distribution/OS: Unspecified
Bug Status: Resolved

Description

The white (#FFFFFF) background is the same color as the scrollbars.
See a screenshot at:
http://sugarlabs.org/~francis/screenshots/iconviewwhite.png

You can see in the right that the scrollbar results to be confusing with the same color as the view.

Attachments (2)

add-border.patch (819 bytes) - added by manuq 8 years ago.
Patch - add border to scrollbar slider.
Captura pantalla de _Diario_.png (71.1 KB) - added by manuq 8 years ago.
Screen grab of the Journal with the patch applied.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by manuq

  • Cc garycmartin added
  • Milestone changed from Unspecified by Release Team to 1.0
  • Priority changed from Unspecified by Maintainer to Normal

Sounds like a good thing to have. I grepped sugar shell and toolkit and there are no references to Gtk.IconView, so the change will not affect them. Could you write a patch, Daniel?

comment:2 follow-up: Changed 8 years ago by danielfrancis

  • Cc manuq added
  • Owner changed from manuq to danielfrancis
  • Status changed from new to assigned

I'm trying to make the patch.
The rule background-color in GtkIconView or GtkIconView.cell (I found the last one in Adwaita) doesn't work.
Works by replacing the rule background-color of .view, but it affects the Journal list. So, I'm reproducing the same bug with short content to scroll in Journal.

Just a purpose: decide and use the same white for Journal, Home View, TreeViews in activities like Log, Chart, et al. and IconViews.

If you only accept to have the same color in IconViews and TreeView, I can 1) look for the right rule or 2) set the light grey background to .view and add rules to set white background to the Journal and HomeView (in list mode).

comment:3 in reply to: ↑ 2 Changed 8 years ago by manuq

Replying to danielfrancis:

Just a purpose: decide and use the same white for Journal, Home View, TreeViews in activities like Log, Chart, et al. and IconViews.

I'm changing my mind about this, our scrollbars should work regardless of the canvas color. We can add a very thin border in the white bar for this.

Changed 8 years ago by manuq

Patch - add border to scrollbar slider.

Changed 8 years ago by manuq

Screen grab of the Journal with the patch applied.

comment:4 Changed 8 years ago by danielfrancis

  • Bug Status changed from Unconfirmed to Resolved
  • Owner changed from danielfrancis to manuq

+1 to your patch. Once you push it to git, this bug is closed.

comment:5 Changed 8 years ago by manuq

Thanks for reviewing Daniel, pushed as e9997ca4 .

comment:6 Changed 8 years ago by manuq

  • Resolution set to fixed
  • Status changed from assigned to closed

Pushed

comment:7 Changed 8 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:8 Changed 8 years ago by dnarvaez

  • Milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.