Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#4224 closed defect (fixed)

Canvas icons: two right-click leaves the background grey

Reported by: manuq Owned by: manuq
Priority: Normal Milestone:
Component: Sugar Version: 0.97.x
Severity: Minor Keywords: r+
Cc: humitos Distribution/OS: Unspecified
Bug Status: Assigned

Description

TestCase:

  • right-click on an icon in the spiral, menu appears
  • right-click again inside the icon

The background stays grey, the dark one used for pressed state.

Attachments (1)

0001-CanvasIcon-do-not-keep-it-ACTIVE-when-right-click-tw.patch​ (1.7 KB) - added by humitos 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Priority changed from Unspecified by Maintainer to Normal
  • Severity changed from Unspecified to Minor
  • Version changed from Unspecified to 0.97.x

Yes, sounds good to fix this one. No highest priority but helps to polish the new hover/press experience.

comment:2 Changed 11 years ago by erikos

  • Keywords triage removed

comment:3 Changed 11 years ago by humitos

  • Cc humitos added

I added some logging on src/sugar3/graphics/icon.py:CanvasIcon and I found that __button_release_cb is not called at all when we right-click on the icons. It seems that the palette block it.

Changed 11 years ago by humitos

comment:4 Changed 11 years ago by humitos

  • Keywords r? added

This patch checks if the palette is being shown when the user clicks on the icon and if not, the ACTIVE flag is set to the icon.

comment:5 Changed 11 years ago by manuq

  • Keywords r+ added; r? removed
  • Resolution set to fixed
  • Status changed from new to closed

Thanks, pushed 1497ebc0 .

comment:6 Changed 11 years ago by dnarvaez

  • Component changed from sugar-toolkit-gtk3 to Sugar

comment:7 Changed 11 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.