Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4164 closed defect (fixed)

Not all Activity titles in Home Favourites view Palettes are truncated

Reported by: garycmartin Owned by: humitos
Priority: Normal Milestone:
Component: Sugar Version: Unspecified
Severity: Minor Keywords: 13.1.0, regression, r+, olpc-test-pending
Cc: humitos, erikos Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

For very long Activity titles, the name in the top of the Palette correctly gets an ellipsis and shortened, but the Activity titles below (for entry resuming) are not truncated and causes the palette to open wider than the display. In previous releases this palette was limited to something like 3/2 of the display width. See attached screen shots of previous release and the current 13.1.0 build with latest test patches.

Change History (11)

comment:1 Changed 8 years ago by manuq

  • Priority changed from Unspecified by Maintainer to Normal
  • Severity changed from Unspecified to Minor

comment:2 Changed 8 years ago by humitos

  • Cc humitos erikos added
  • Component changed from sugar-artwork to sugar
  • Keywords r? added
  • Owner changed from manuq to humitos
  • Status changed from new to accepted

Well, I found this was lost when PaletteMenuItem was added in 2d0ac2a95219992ac5be003816fdb97ff5f6af6f of sugar source code.

That class does not handle the text_maxlen argument (default to 60). I used this argument to set the Gtk.Label's size: label.set_max_width_chars and use MIDDLE for its EllipSizeMode as sugar3.graphics.palette.Palette does for its title and subtitle.

With these settings, the title of the palette and its items share the same behaviour and are rendered with the same width.

comment:3 Changed 8 years ago by humitos

  • Component changed from sugar to sugar-toolkit-gtk3

Changed 8 years ago by humitos

Screenshot after aplying the patch

comment:4 Changed 8 years ago by manuq

  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from accepted to closed

Great, I have tested with 12.1 build and the middle ellipsize is used too. Pushed as b7296805 .

comment:5 Changed 8 years ago by greenfeld

If this is fixed it is not in sugar-toolkit-gtk3-0.98.3-1 (in OLPC 13.1.0 os24).

comment:6 Changed 8 years ago by dnarvaez

  • Component changed from sugar-toolkit-gtk3 to Sugar

comment:7 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.