Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#3997 closed task (fixed)

use long-press signal to invoke Palette

Reported by: erikos Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Browse Version: 0.97.x
Severity: Major Keywords: r?
Cc: manuq Distribution/OS: OLPC
Bug Status: Assigned

Description

should be the same as right click

Attachments (2)

pressed.patch (2.5 KB) - added by erikos 9 years ago.
first implementation, missing the differntiation between the click and the long press
0001-Touch-on-long-press-on-a-link-or-image-show-the-Pale.patch (4.2 KB) - added by erikos 9 years ago.
Touch: on long-press on a link or image show the Palette

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by erikos

first implementation, missing the differntiation between the click and the long press

Changed 9 years ago by erikos

Touch: on long-press on a link or image show the Palette

comment:1 Changed 9 years ago by erikos

  • Cc manuq added
  • Keywords r? added

The above patch does implement the desired behaviour, a detailed description is in the commit message.

When playing with it on the XO (os5) I see the following issues:

  • text selection gets sometimes in the way
  • it can be that there are no long-press events any more after a while, only normal tap/clicks do work
  • I have seen the case where a short tap would trigger a right click action and display the Palette

Nice to have:

  • better feedback on the link when you do a long press, have a grey border or similar


comment:2 Changed 9 years ago by garycmartin

Is the long press realtime feedback working with this patch (circle clockwise timer)? If so is this something I can now theme, it needs to be larger so not to be hidden behind the finger, and better contrast and Sugar theme. I was considering a larger circle shrinking down to the current circle size, same black/white style as the touch handles.

comment:3 Changed 9 years ago by manuq

  • Resolution set to fixed
  • Status changed from new to closed

Is in 2e2d4817 .

comment:4 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.