Opening the control panel should not auto focus on its search area unless characters are typed

[garycmartin]

To prevent the OSK from opening unnecessarily, the control panel should not auto focus on its search area, unless characters are typed, much like we now do for the home zoom views and the Journal search areas.

[garycmartin]

In ebook mode, the CP (My Settings) is still partly obscured by the OSK as the search field is focused by default. As text search in the CP is a _very_ rare function, perhaps the low cost option is to not auto focus on the CP search area?

[erikos]

CP: Unfocus search, focus on startingto type

[erikos]

Above patch introduces a string addition ('Control Panel'), question for Chris if this ok.

@manuq: there is an issue in the patch, only one character is used at a time, maybe you can check that.

[garycmartin]

Replying to erikos:

Above patch introduces a string addition ('Control Panel'), question for Chris if this ok.

@manuq: there is an issue in the patch, only one character is used at a time, maybe you can check that.

Thanks :) Just tested the patch:

• the OSK is only very intermittently raising when the touching search field to focus it for entering a query. After much screen tapping it appears to only trigger if you first tap outside of the CP dialogue box, on the background parent view, and then back on the CP search field to get the OSK to trigger. This is also the same for any text widgets inside the various CP modules e.g. the About Me name input widget, the Date & Time search widget, or the Network server name widget.
• focusing the search field usually results in text selecting some part of the grey 'Search in Control Panel' hint text
• Suggest the hint string should be 'Search in Settings' so that we use the same language as else where in the user facing strings (CP is only the implementation name now)

[cjl]

Replying to erikos:

Above patch introduces a string addition ('Control Panel'), question for Chris if this ok.

With a milestone of 0.98, this would not be under any "string freeze" of any sort, so why not?

If you want to backport, we have this string

../src/jarabe/controlpanel/cmd.py:31
sugar-control-panel: %s

A version that just dropped the %s would be easy to copy/modify from existing entries, I could handle it myself for any language.

[erikos]

Replying to garycmartin:

Replying to erikos:

Above patch introduces a string addition ('Control Panel'), question for Chris if this ok.

@manuq: there is an issue in the patch, only one character is used at a time, maybe you can check that.

Thanks :) Just tested the patch:

• the OSK is only very intermittently raising when the touching search field to focus it for entering a query. After much screen tapping it appears to only trigger if you first tap outside of the CP dialogue box, on the background parent view, and then back on the CP search field to get the OSK to trigger. This is also the same for any text widgets inside the various CP modules e.g. the About Me name input widget, the Date & Time search widget, or the Network server name widget.
• focusing the search field usually results in text selecting some part of the grey 'Search in Control Panel' hint text
• Suggest the hint string should be 'Search in Settings' so that we use the same language as else where in the user facing strings (CP is only the implementation name now)

Agreed with the name, the issue is the focusing problem, I have no idea yet what is causing it. Already lost too much time on it. If someone has an idea...

[erikos]

I would add the place holder string now, so we do not have the issue with breaking the freeze (has no visual impact).

diff --git a/src/jarabe/controlpanel/toolbar.py b/src/jarabe/controlpanel/toolbar.py
index 2094d3b..1423e94 100644
--- a/src/jarabe/controlpanel/toolbar.py
+++ b/src/jarabe/controlpanel/toolbar.py
@@ -53,6 +53,8 @@ class MainToolbar(Gtk.Toolbar):
                                               'system-search')
         self._search_entry.add_clear_button()
         self._search_entry.set_width_chars(25)
+        text = _('Search in %s') % _('Settings')
+        self._search_entry.set_placeholder_text(text)
         self._search_entry.connect('changed', self.__search_entry_changed_cb)
         tool_item.add(self._search_entry)
         self._search_entry.show()

[erikos]

Pushed placeholder after agreeing with Manuel: ​http://git.sugarlabs.org/sugar/mainline/commit/fcd748939996fa1f970244f8ef8680677ec128c0

[manuq]

Candidate patch.

[manuq]

Updated candidate patch with Simon suggestion, clear the search when a section is closed.

[manuq]

Pushed ff734de4 .

[greenfeld]

Fixed in OLPC 13.1.0 os8.

[dnarvaez]

Milestone 0.98 deleted