Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#3907 closed defect (fixed)

Browse Download Alert: Timeout icon does not draw correctly

Reported by: erikos Owned by: manuq
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: 0.97.x
Severity: Blocker Keywords:
Cc: humitos Distribution/OS: OLPC
Bug Status: Assigned

Description

It is a white square.

Attachments (2)

0001-Alert-use-GtkStyleContext-instead-of-deprecated-GtkS.patch (1.3 KB) - added by manuq 7 years ago.
Fix for the toolkit-gtk3 .
0001-Add-border-redius-to-SugarTimeoutIcon-SL-3907.patch (1007 bytes) - added by manuq 7 years ago.
Fix for the artwork.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by erikos

  • Severity changed from Major to Blocker

comment:2 Changed 7 years ago by manuq

  • Owner changed from erikos to manuq
  • Status changed from new to assigned

comment:3 follow-up: Changed 7 years ago by humitos

  • Cc humitos added

I'm getting this trace in the log:

** (sugar-activity:19785): CRITICAL **: Stack overflow protection. Can't copy array element into GIArgument.
Traceback (most recent call last):
  File "/home/humitos/sugar-build/install/lib/python2.7/site-packages/sugar3/graphics/alert.py", line 354, in __draw_cb
    self._draw(context)
  File "/home/humitos/sugar-build/install/lib/python2.7/site-packages/sugar3/graphics/alert.py", line 373, in _draw
    color = widget_style.bg[self.get_state()]
IndexError: list index out of range

comment:4 in reply to: ↑ 3 Changed 7 years ago by manuq

Replying to humitos:

I'm getting this trace in the log:

** (sugar-activity:19785): CRITICAL **: Stack overflow protection. Can't copy array element into GIArgument.
Traceback (most recent call last):
  File "/home/humitos/sugar-build/install/lib/python2.7/site-packages/sugar3/graphics/alert.py", line 354, in __draw_cb
    self._draw(context)
  File "/home/humitos/sugar-build/install/lib/python2.7/site-packages/sugar3/graphics/alert.py", line 373, in _draw
    color = widget_style.bg[self.get_state()]
IndexError: list index out of range

Good catch, I'm attaching a possible fix.

Changed 7 years ago by manuq

Fix for the toolkit-gtk3 .

Changed 7 years ago by manuq

Fix for the artwork.

comment:5 Changed 7 years ago by manuq

  • Resolution set to fixed
  • Status changed from assigned to closed

Pushed artwork fix to 8b46c6d1 and toolkit-gtk3 fix to 76da9331 .

comment:6 Changed 6 years ago by dnarvaez

  • Component changed from sugar-toolkit-gtk3 to Sugar

comment:7 Changed 6 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.