Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#3906 closed defect (fixed)

Screenshot taking is broken

Reported by: erikos Owned by: manuq
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: 0.97.x
Severity: Blocker Keywords: 13.1.0
Cc: erikos Distribution/OS: OLPC
Bug Status: Assigned

Description


Attachments (1)

0001-Fix-screenshot-extension-port-to-cairo-SL-3906.patch (4.3 KB) - added by manuq 7 years ago.
Proposed patch.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by erikos

Traceback (most recent call last):
  File "/home/erikos/sugar-build/install/lib/python2.7/site-packages/jarabe/view/keyhandler.py", line 182, in _key_pressed_cb
    action.handle_key_press(key)
  File "/home/erikos/sugar-build/install/share/sugar/extensions/globalkey/screenshot.py", line 41, in handle_key_press
    width, height = window.get_size()
AttributeError: 'X11Window' object has no attribute 'get_size'

Changed 7 years ago by manuq

Proposed patch.

comment:2 Changed 7 years ago by manuq

  • Cc erikos added
  • Keywords 13.1.0 added
  • Owner changed from erikos to manuq
  • Status changed from new to assigned

Besides the API fix (we now have get_width and get_height instead of get_size), the code needed to be ported to Cairo. The proposed patch does it.

comment:3 Changed 7 years ago by manuq

  • Resolution set to fixed
  • Status changed from assigned to closed

Pushed as 898827d8 .

comment:4 Changed 6 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.