Tabbinghandler not working

[erikos]

Gdk.keyboard_grab(window, False) takes 3 arguments (tabbinghandler.py)

[erikos]

deprecated: ​http://developer.gnome.org/gdk3/stable/gdk3-General.html#gdk-keyboard-grab

to use: ​http://developer.gnome.org/gdk3/stable/GdkDevice.html#gdk-device-grab

Gdk.Device.grab

[manuq]

It doesn't seem to be a direct way to get the keyboard device, but we can get a list of the master devices that should include it:

        display = Gdk.Display.get_default()
        device_manager = display.get_device_manager()
        self._devices = device_manager.list_devices(Gdk.DeviceType.MASTER)

Also we need the pointer device. There is a direct way for this one, and the list of devices includes it. In my system is the second element:

        self._pointer_device = device_manager.get_client_pointer()
        assert self._pointer_device == self._devices[1]

[manuq]

Partial, unfinished patch.

[manuq]

Partial patch attached. I'm not sure about the parameters passed to the device.grab() method.

Pressing Alt-Tab I can switch to the next activity but then Sugar hangs. Log shows that device.ungrab() is not being called.

[tonyforster]

still present in OS3

[erikos]

Replying to tonyforster:

still present in OS3

Thanks for testing again Tony. But if the ticket is still open there has not been a fix. Most of the time things don't get magically fixed :)

[godiard]

New patch based in manuq work

[godiard]

I have uploaded a new patch for review.

This patch use the deprecated gdk-keyboard-grab, gdk-pointer-grab. Now I see it working, if we want, we can try use the new api.

Is not clear for me, why we need grab the mouse.

Another strange issue (may be a bug a lower levels) is after testing a lot, I can see cases where the mask returned by window.get_pointer() is 0, then the keyboard and mouse are not ungrabed. I have modified the condition to ungrab in that situation too.

[erikos]

testing patch with new API

[erikos]

Replying to godiard:

I have uploaded a new patch for review.

This patch use the deprecated gdk-keyboard-grab, gdk-pointer-grab. Now I see it working, if we want, we can try use the new api.

I have attached a patch with the new API. Works the same as yours. Both do not show the Frame when tabbing. This is because right after grabbing we ungrab again. We have to compare with the old code.

Furthermore we should check how to handle the devices. Cache the keyboard device (like in my example patch)? Always request from new? How do we handle keyboards that are attached?

Is not clear for me, why we need grab the mouse.

To me is not clear neither. Tested on 12.1.0 without grabbing the mouse and it worked as expected. We should ask Benzea if we miss anything.

Another strange issue (may be a bug a lower levels) is after testing a lot, I can see cases where the mask returned by window.get_pointer() is 0, then the keyboard and mouse are not ungrabed. I have modified the condition to ungrab in that situation too.

[erikos]

keygrabber: Handle XI2 key events (toolkit-gtk3)

[erikos]

The two latest patches brings back the tabbing functionality. We needed to patch as well the keygrabber to handle XI2 key events to get this working.

Only remaining item (can be done later) is to port gdk-window-get-pointer to gdk_window_get_device_position ​http://developer.gnome.org/gdk3/stable/gdk3-Windows.html#gdk-window-get-pointer

[godiard]

A few comments:

• In my devel system (sugar-build, F17) window.get_pointer() returns:

(<X11Window object at 0x2e2af50 (GdkX11Window at 0x2daf480)>, 235, 204, <flags GDK_MOD1_MASK of type GdkModifierType>)

then, there are one parameter more, and the code break. I don't know if we should check this, and try avoid the error, or if is something wrong in my system.

• With your patches, I couldn't reproduce the situation where I received 0 in the mask.

• I don't have a 12.1.0 system now to compare if the frame behavior changed, I see a little annoying showing it in the middle, but at the same time, look change the activity button, at top, is good. Is too late to design/discuss changes now, we hould keep how was working.

• After changing the window.get_pointer() line, all works here.

[erikos]

Tabbinghandler: port the tabbinghandler to the new GTK+3 API

[godiard]

New patch tested and working as expected.

[erikos]

shell: af7b783866fb92d715d128f777ba3ae802949f7e

toolkit-gtk3: a22d4ee50d362eb1f638111d287c81af70a8f5fc

[dnarvaez]

Milestone 0.98 deleted