Icon/EventIcon: badge is not drawn at the correct position

[erikos]

Has to be fixed for the shell port (we draw badges in the Neighborhood View (AP icons)).

Patch to test with HelloWorld attached.

[erikos]

test with HelloWorld

[erikos]

Test patch for the toolkit-gtk3:

diff --git a/src/sugar3/graphics/icon.py b/src/sugar3/graphics/icon.py
index c10273e..956ea44 100644

--- a/src/sugar3/graphics/icon.py
+++ b/src/sugar3/graphics/icon.py
@@ -304,7 +304,7 @@ class _IconBuffer(object):
 
         if self.badge_name:
             context.restore()
-            context.translate(badge_info.attach_x, badge_info.attach_y)
+            context.translate(badge_info.attach_x + 10, badge_info.attach_y + 10)
             self._draw_badge(context, badge_info.size, sensitive, widget)
 
         self._surface_cache[cache_key] = surface

[manuq]

erikos testcase as a testcase for the toolkit testsuit

[manuq]

in icon.py, _get_attach_points() is returning (0, 0). The pygi-convert.sh in commit 820efa56 did it:

-        attach_points = info.get_attach_points()
+        return 0,0;has_attach_points_, attach_points = info.get_attach_points()

[manuq]

Yes the previous patch fixes it. I was confused by the testcase, which is wrong. 'document-open' is not good for a testcase because it doesn't have attach points. They are defined in the artwork .icon files, for example 'network-wireless-000' has:

[Icon Data]
AttachPoints=970,850

As per ​this freedesktop spec.

[erikos]

Yeah, pushed as: c0756f48d4f75702e3d419c1737cfdd837dd9ca3

[dnarvaez]

Milestone 0.98 deleted