#3403 closed defect (fixed)
Read: theme the bookmark dialog and the bookmark itself
| Reported by: | erikos | Owned by: | erikos |
|---|---|---|---|
| Priority: | Unspecified by Maintainer | Milestone: | |
| Component: | Sugar | Version: | Git as of bugdate |
| Severity: | Major | Keywords: | 12.1.0, patch |
| Cc: | humitos | Distribution/OS: | OLPC |
| Bug Status: | Unconfirmed |
Description
At the moment they are grey, should be in sugar style (not sure how they were before with the old theme).
Attachments (5)
Change History (20)
comment:1 Changed 11 years ago by godiard
comment:2 Changed 11 years ago by godiard
The change applied in the activity is in commit 0c4072cd9667222df883684ae26364c973c90773
comment:3 Changed 11 years ago by humitos
- Keywords patch added
comment:4 follow-up: ↓ 5 Changed 11 years ago by humitos
- Cc humitos added
erikos sent a patch to the mailing list that fix the tooltip shown when the cursor is over the Bookmark star at the left of the screen:
I tested it and works. I'm uploading two screenshots that show the change.
comment:5 in reply to: ↑ 4 Changed 11 years ago by garycmartin
Replying to humitos:
erikos sent a patch to the mailing list that fix the tooltip shown when the cursor is over the Bookmark star at the left of the screen:
I tested it and works. I'm uploading two screenshots that show the change.
Yes, that looks much better, and more consistent with the rest of Sugar, thanks for the screen grab! :)
comment:6 Changed 11 years ago by godiard
- Component changed from Read to sugar-artwork
- Owner changed from godiard to erikos
Thanks Simon!.
Change component to sugar-artwork.
comment:7 Changed 11 years ago by erikos
Ok, the tooltip part has been pushed: http://git.sugarlabs.org/sugar-artwork/mainline/commit/bc49932c35b12b12facf340bff1ea9298b6f122b
The borders Re handled in #3561, so we can close this one.
comment:8 Changed 11 years ago by erikos
- Status changed from new to assigned
comment:9 Changed 11 years ago by erikos
- Resolution set to fixed
- Status changed from assigned to closed
comment:10 Changed 11 years ago by manuq
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to fix the toolbar background.
comment:11 Changed 11 years ago by manuq
- Resolution set to fixed
- Status changed from reopened to closed
So eriko's tooltip style landed already, and the other things were fixed in #3561. Thanks all for your work, closing.
comment:12 Changed 11 years ago by manuq
- Milestone changed from 0.96 to 0.98
- Resolution fixed deleted
- Status changed from closed to reopened
We were wrong. Our toolbars are toolbar_grey color as defined in the gtk.css and in the toolkit style.py.
Here is the fix:
--- a/gtk3/theme/gtk-widgets.css.em
+++ b/gtk3/theme/gtk-widgets.css.em
@@ -527,7 +527,7 @@ GtkVSeparator, GtkHSeparator,
.toolbar {
padding: 0px;
-background-color: @black;
+background-color: @toolbar_grey;
}
comment:13 Changed 11 years ago by manuq
- Resolution set to fixed
- Status changed from reopened to closed
Fixed the last bit in artwork commit b6bd6b89 .
comment:14 Changed 10 years ago by dnarvaez
- Component changed from sugar-artwork to Sugar
Added a temporary solution in Read code. Probably should be fixed in sugar-artwork