Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#3403 closed defect (fixed)

Read: theme the bookmark dialog and the bookmark itself

Reported by: erikos Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Major Keywords: 12.1.0, patch
Cc: humitos Distribution/OS: OLPC
Bug Status: Unconfirmed

Description

At the moment they are grey, should be in sugar style (not sure how they were before with the old theme).

Attachments (5)

read-bookmark-gtk2.png (91.9 KB) - added by manuq 11 years ago.
This is how it looked like in GTK2
Captura pantalla de _test.pdf___OLD.png (73.8 KB) - added by humitos 11 years ago.
Before applying the erikos' patch
Captura pantalla de _test.pdf_.png (132.7 KB) - added by humitos 11 years ago.
After applying the erikos' patch
0001-Make-toolbars-black-background-SL-3403.patch (989 bytes) - added by manuq 11 years ago.
Make toolbars black background.
0001-Revert-Temporary-solution-to-SL-3403-SL-3561.patch (1.6 KB) - added by manuq 11 years ago.
Revert workaround for Read

Download all attachments as: .zip

Change History (20)

comment:1 Changed 11 years ago by godiard

Added a temporary solution in Read code. Probably should be fixed in sugar-artwork

comment:2 Changed 11 years ago by godiard

The change applied in the activity is in commit 0c4072cd9667222df883684ae26364c973c90773

comment:3 Changed 11 years ago by humitos

  • Keywords patch added

Changed 11 years ago by manuq

This is how it looked like in GTK2

comment:4 follow-up: Changed 11 years ago by humitos

  • Cc humitos added

erikos sent a patch to the mailing list that fix the tooltip shown when the cursor is over the Bookmark star at the left of the screen:

I tested it and works. I'm uploading two screenshots that show the change.

Changed 11 years ago by humitos

Before applying the erikos' patch

Changed 11 years ago by humitos

After applying the erikos' patch

comment:5 in reply to: ↑ 4 Changed 11 years ago by garycmartin

Replying to humitos:

erikos sent a patch to the mailing list that fix the tooltip shown when the cursor is over the Bookmark star at the left of the screen:

I tested it and works. I'm uploading two screenshots that show the change.

Yes, that looks much better, and more consistent with the rest of Sugar, thanks for the screen grab! :)

comment:6 Changed 11 years ago by godiard

  • Component changed from Read to sugar-artwork
  • Owner changed from godiard to erikos

Thanks Simon!.

Change component to sugar-artwork.

comment:7 Changed 11 years ago by erikos

Ok, the tooltip part has been pushed: http://git.sugarlabs.org/sugar-artwork/mainline/commit/bc49932c35b12b12facf340bff1ea9298b6f122b

The borders Re handled in #3561, so we can close this one.

comment:8 Changed 11 years ago by erikos

  • Status changed from new to assigned

comment:9 Changed 11 years ago by erikos

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:10 Changed 11 years ago by manuq

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to fix the toolbar background.

Changed 11 years ago by manuq

Make toolbars black background.

comment:11 Changed 11 years ago by manuq

  • Resolution set to fixed
  • Status changed from reopened to closed

So eriko's tooltip style landed already, and the other things were fixed in #3561. Thanks all for your work, closing.

Changed 11 years ago by manuq

Revert workaround for Read

comment:12 Changed 10 years ago by manuq

  • Milestone changed from 0.96 to 0.98
  • Resolution fixed deleted
  • Status changed from closed to reopened

We were wrong. Our toolbars are toolbar_grey color as defined in the gtk.css and in the toolkit style.py.

Here is the fix:

--- a/gtk3/theme/gtk-widgets.css.em
+++ b/gtk3/theme/gtk-widgets.css.em
@@ -527,7 +527,7 @@ GtkVSeparator, GtkHSeparator,
 
 .toolbar {
 padding: 0px;
-background-color: @black;
+background-color: @toolbar_grey;
 }

comment:13 Changed 10 years ago by manuq

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed the last bit in artwork commit b6bd6b89 .

comment:14 Changed 10 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:15 Changed 10 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.