'show' block with video clock crashes TA if object is not video

[garycmartin]

Testing in TA 116, the 'show' block with a video object attached draws a grey rectangle and then crashes TA if object was not actually video media. Would be great if there was some test done on it before trying to play the media. I accidently selected still png images by mistake the first few times I tried this block. Perhaps the icon representing the 'Sugar journal media object' could also be changed from the Journal icon to that of the Image viewer type picture frame?

[walter]

Hmm. My test must be failing. Will check it. Re the Journal icon, you can use it to open any Journal object. If it is not an image, it will try to use the preview image. So maybe I should add a block that is specifically for images???

[walter]

Was there an except raised in the log file?

[walter]

I cannot seem to reproduce this error... a log file would help.

[garycmartin]

Replying to walter:

I cannot seem to reproduce this error... a log file would help.

Here's the log. Steps to reproduce the cash:

1) drag on the 'show' brick
2) drag on the 'video object' and use it to replace the default 'text' object
3) click the 'video object' and chose an image (e.g. a Paint activity, a screen shot, or a downloaded png image)
4) click 'show' once to run the brick

You briefly see a grey box and then TA will crash.

[walter]

I think I have fixed the problem with movies crashing in general.

​http://git.sugarlabs.org/turtleart/mainline/commit/7d5b1dffa0e28c7e06c5f585311aaae18a8a646d

I cannot otherwise reproduce this bug. Please pull and test.

[walter]

When I try to reproduce this bug since fixing the general issues with movie playback, I cannot crash TA. When repeating the steps above, I get an image displayed. Please reopen this ticket if the problem persists.