Opened 13 years ago
Closed 13 years ago
#2094 closed defect (fixed)
hide mesh device icon when inactive
Reported by: | dsd | Owned by: | tomeu |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | Unspecified |
Component: | Sugar | Version: | Unspecified |
Severity: | Unspecified | Keywords: | r+ |
Cc: | erikos | Distribution/OS: | Unspecified |
Bug Status: | Unconfirmed |
Description
Based on #2086 and a mailing list discussion, we should hide the mesh device icon when the connection is inactive.
Attachments (1)
Change History (3)
Changed 13 years ago by dsd
comment:1 Changed 13 years ago by tomeu
- Keywords r+ added; r? removed
comment:2 Changed 13 years ago by dsd
- Resolution set to fixed
- Status changed from new to closed
The "del" is indeed pointless, I removed it but there are other offenders in the same file.
I left the logging message the same. A traceback would not be interesting as it comes straight from dbus. There are many other "offenders" in this code too.
Changed the state thing and pushed, thanks.
Note: See
TracTickets for help on using
tickets.
+ del self._device_view
+ self._device_view = None
Is that del really needed?
+ logging.error('Error getting the device properties: %s', err)
May be better to raise an exception so we have the traceback.
+ if state >= network.DEVICE_STATE_PREPARE \
+ and state <= network.DEVICE_STATE_ACTIVATED:
I personally think we should treat that as an enum and don't assume anything about the integer values of the enum values, but I see we are already doing it somewhere else.
Please push when you think these concerns have been addressed.