Opened 11 years ago

Closed 11 years ago

#2086 closed defect (fixed)

mesh device icon always shows active state

Reported by: dsd Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords: olpc-0.84
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

The mesh icon is always showing the device as active. Looks like I uploaded the wrong patch during the review stages.

Attachments (1)

0001-Indicate-inactive-state-in-mesh-device-icon.patch (3.3 KB) - added by dsd 11 years ago.
fix

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Keywords r+ added; r? removed

Thanks Daniel for the patch. The code looks good and it is working well.

I even wonder a bit if we need to show the device at all when we are not connected. That is what we do for the wired device for example. And I think we show the wireless device only because we have the 'create new network' option in there. I remember Eben had a full and convincing view on those things. Maybe you can get his input.

If time critical, I would argue that you can push your code to at least the 0.84 branch, as it fixes the bug.

comment:2 Changed 11 years ago by erikos

  • Keywords olpc-0.84 added

comment:3 Changed 11 years ago by dsd

  • Keywords r+ removed

Good point. With agreement from Tomeu, I've pushed out the patch to master and 0.84 because it's an improvement on the behaviour we have already (mesh device always shown in frame). I'll start a design discussion now regarding hiding it when not in use (sounds like a good idea to me too) and will follow up with further patches if we decide to change.

comment:4 Changed 11 years ago by erikos

Awesome, thanks Daniel!

comment:5 Changed 11 years ago by dsd

  • Resolution set to fixed
  • Status changed from new to closed

filed #2094 to hide the device when not in used.

Note: See TracTickets for help on using tickets.