bundlebuilder chokes on git submodules

[sascha_silbe]

Pippy ​FTBFS for quite some time now because bundlebuilder chokes on git submodules:

Traceback (most recent call last):
  File "setup.py", line 21, in <module>
    bundlebuilder.start()
  File "/home/buildslave/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/activity/bundlebuilder.py", line 418, in start
    globals()['cmd_' + args[0]](config, args[1:])
  File "/home/buildslave/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/activity/bundlebuilder.py", line 343, in cmd_install
    installer.install(suboptions.prefix)
  File "/home/buildslave/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/activity/bundlebuilder.py", line 275, in install
    shutil.copy(source, dest)
  File "/usr/lib/python2.6/shutil.py", line 84, in copy
    copyfile(src, dst)
  File "/usr/lib/python2.6/shutil.py", line 51, in copyfile
    with open(dst, 'wb') as fdst:
IOError: [Errno 13] Permission denied: '/home/buildslave/sugar-jhbuild/install/share/sugar/activities/Pippy.activity/dobject/.git/objects/pack/pack-50d5617ffbf6a5c020782

bundlebuilder should probably ignore all "hidden" directories (i.e. those starting with a dot).

[mtd]

This problem still exists for me:

Install locale/nl/activity.linfo to /home/martin/src/sugar-jhbuild/install/share/sugar/activities/Pippy.activity/locale/nl/activity.linfo.
Install dobject/.git/objects/pack/pack-50d5617ffbf6a5c02078289b04469d28188200fd.pack to /home/martin/src/sugar-jhbuild/install/share/sugar/activities/Pippy.activity/dobject/.git/objects/pack/pack-50d5617ffbf6a5c02078289b04469d28188200fd.pack.
Traceback (most recent call last):
  File "setup.py", line 21, in <module>
    bundlebuilder.start()
  File "/home/martin/src/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/activity/bundlebuilder.py", line 418, in start
    globals()['cmd_' + args[0]](config, args[1:])
  File "/home/martin/src/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/activity/bundlebuilder.py", line 343, in cmd_install
    installer.install(suboptions.prefix)
  File "/home/martin/src/sugar-jhbuild/install/lib/python2.6/site-packages/sugar/activity/bundlebuilder.py", line 275, in install
    shutil.copy(source, dest)
  File "/usr/lib/python2.6/shutil.py", line 88, in copy
    copyfile(src, dst)
  File "/usr/lib/python2.6/shutil.py", line 53, in copyfile
    fdst = open(dst, 'wb')
IOError: [Errno 13] Permission denied: '/home/martin/src/sugar-jhbuild/install/share/sugar/activities/Pippy.activity/dobject/.git/objects/pack/pack-50d5617ffbf6a5c02078289b04469d28188200fd.pack'
*** Error during phase install of pippy: ########## Error running python setup.py install --prefix /home/martin/src/sugar-jhbuild/install *** [23/28]

[mtd]

Sorry - I don't think this fixes it.

[mtd]

This one works better (the pattern is broader).

I'm not sure that this approach is right as I really don't know enough context.

But this patch fixes the specific symptom: pippy builds now from jhbuild.

[m_anish]

Try building again from the latest pippy/mainline snapshot (after cleaning your local repo). This ​commit should have fixed the problem.