Opened 12 years ago

Closed 12 years ago

#20 closed defect (fixed)

hulahop_get_view_for_window implicitly converted to pointer

Reported by: morgs Owned by: marcopg
Priority: minor Milestone:
Component: hulahop Version:
Severity: Keywords: r+
Cc: Distribution/OS:
Bug Status:

Description

Debian http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505459

Package: sugar-hulahop
Version: 0.4.7~dfsg-1
Severity: serious
Tags: patch
Usertags: implicit-pointer-conversion

Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.

Function `hulahop_get_view_for_window' implicitly converted to pointer at hulahop.c:315
Function `hulahop_get_view_for_window' implicitly converted to pointer at hulahop.c:315

This is often due to a missing function prototype definition.
For more information, see [2].

Though it is guaranteed that this codepath will cause a segfault on certain
architectures, it is not guaranteed that this codepath would ever be executed
(e.g., if the returned pointer is never dereferenced). However, this bug
does prevent the ia64 buildd from successfully building this package, resulting
in a practical FTBFS issue and warranting the serious severity.

The following patch appears to fix the problem for me - there
certainly maybe better ways to do it.

[1] http://people.debian.org/~dannf/check-implicit-pointer-functions
[2] http://wiki.debian.org/ImplicitPointerConversions

--- sugar-hulahop-0.4.7~dfsg/python/hulahop.override~   2008-10-08 04:50:05.000000000 -0600
+++ sugar-hulahop-0.4.7~dfsg/python/hulahop.override    2008-11-12 09:02:25.000000000 -0700
@@ -4,6 +4,7 @@
 #include <Python.h>
 #include <pygtk/pygtk.h>

+#include "hulahop.h"
 #include "hulahop-web-view.h"

 %%

Change History (3)

comment:1 Changed 12 years ago by marcopg

  • Component changed from sugar to hulahop

comment:2 Changed 12 years ago by marcopg

  • Keywords r+ added

Please follow the CodeReview process. Patch looks fine.

comment:3 Changed 12 years ago by morgs

  • Resolution set to fixed
  • Status changed from new to closed

Pushed to master.

Note: See TracTickets for help on using tickets.