#19 closed enhancement (fixed)
add star badge to APs that are in our connections
Reported by: | erikos | Owned by: | erikos |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Sugar | Version: | Git as of bugdate |
Severity: | Minor | Keywords: | r+ |
Cc: | Distribution/OS: | Unspecified | |
Bug Status: | Assigned |
Description
each AP that is in our connections config file needs to have a star badge (favi icon)
Change History (9)
comment:1 Changed 15 years ago by erikos
- Milestone set to 0.84
- Owner changed from marcopg to erikos
- Priority changed from major to normal
- Status changed from new to assigned
- Version set to Git as of bugdate
comment:2 Changed 15 years ago by gregdek
- Bug Status set to Assigned
- Distribution/OS set to Unspecified
- Severity set to Blocker
- Type changed from defect to enhancement
comment:3 Changed 15 years ago by tomeu
- Milestone changed from 0.84 to 0.86
Moving to 0.86 as per Greg's comment
comment:4 Changed 14 years ago by erikos
- Cc r? added
diff --git a/src/jarabe/desktop/meshbox.py b/src/jarabe/desktop/meshbox.py index c37bba1..be33d0f 100644 --- a/src/jarabe/desktop/meshbox.py +++ b/src/jarabe/desktop/meshbox.py @@ -217,7 +217,10 @@ class AccessPointView(CanvasPulsingIcon): logging.debug('Error getting the access point properties: %s', err) def _update(self): - if self._flags == network.NM_802_11_AP_FLAGS_PRIVACY: + if network.find_connection(self._name) != None: + self.props.badge_name = "emblem-favorite" + self._palette_icon.props.badge_name = "emblem-favorite" + elif self._flags == network.NM_802_11_AP_FLAGS_PRIVACY: self.props.badge_name = "emblem-locked" self._palette_icon.props.badge_name = "emblem-locked"
comment:5 Changed 14 years ago by erikos
- Severity changed from Blocker to Minor
comment:6 Changed 14 years ago by tomeu
- Cc r? removed
- Keywords r? added
comment:7 Changed 14 years ago by tomeu
- Keywords r+ added; r? removed
None is a singleton, so better do "is not None" instead of !=, see PEP for a longer explanation.
r+ with that nitpick
comment:8 Changed 14 years ago by tomeu
- Resolution set to fixed
- Status changed from assigned to closed
Note: See
TracTickets for help on using
tickets.
Not major. Moving to 0.86 release.