Opened 14 years ago
Closed 14 years ago
#2 closed defect (fixed)
wpa support for NM07 in sugar head
Reported by: | erikos | Owned by: | erikos |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | Sugar | Version: | |
Severity: | Keywords: | r+ | |
Cc: | morgan.collett@… | Distribution/OS: | |
Bug Status: |
Description
- adds the loading and saving of the connections file
- support of wpa
- cleaning up the dialogs (looked what nm-applet is doing)
Attachments (1)
Change History (8)
comment:1 Changed 14 years ago by erikos
comment:2 Changed 14 years ago by marcopg
- Component changed from glucose to sugar
- Owner changed from tomeu to marcopg
comment:3 Changed 14 years ago by erikos
- Owner changed from marcopg to erikos
- Status changed from new to assigned
comment:4 Changed 14 years ago by morgs
- Cc morgan.collett@… added
Changed 14 years ago by erikos
does include better error handling for reading the config file and move the settings and secrets to python objects
comment:5 Changed 14 years ago by erikos
- Keywords r? added
comment:6 Changed 14 years ago by tomeu
- Keywords r+ added; r? removed
Though we should make translatable that 'Auto ' string and try to keep abbreviations to the minimum possible.
comment:7 Changed 14 years ago by erikos
- Resolution set to fixed
- Status changed from assigned to closed
Done and pushed - thanks for the review!
Note: See
TracTickets for help on using
tickets.
tomeu comments:
I would prefer to explicitly return None, and test for that value in the callers. Though the most usual solution would be to return a tuple or an object with those properties as members.
This construction should be used only when security is a boolean or a sequence. If you want to check if it's None, just do "if security is None".
Couldn't this be done in a nice "for key in ['key-mgmt', 'proto', ...]:" loop?
What this else clause does?
I'm a bit concerned about all these strings in the code, cannot we use a python object with some properties instead?
Globally, this patch sounds pretty good to me.