Opened 11 years ago

Closed 8 years ago

Last modified 7 years ago

#1680 closed enhancement (incomplete)

sugar-base: add sugar.dispatch.DbusSignal

Reported by: sascha_silbe Owned by: sascha_silbe
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Unspecified Keywords: r?
Cc: tomeu Distribution/OS: Unspecified
Bug Status: Assigned

Description

This patch adds the classes sugar.dispatch.RelayedSignal and sugar.dispatch.DbusSignal.

RelayedSignal is a base class for distributing signals from some external sources. The external source will usually only be attached if there are actually (internal) listeners to prevent unnecessary overhead.

DbusSignal (deriving from RelayedSignal) relays DBus signals which can be passed either via full name specification (looked up and connected to only on demand) or as an interface instance (in case the caller already got one).

It is intended to provide data store listeners in sugar.datastore.datastore that only listen to the DBus signals if there's actually someone listening for it, thus reducing overhead.

Attachments (1)

0001-add-classes-sugar.dispatch.RelayedSignal-and-sugar.d.patch (4.7 KB) - added by sascha_silbe 11 years ago.
add classes sugar.dispatch.RelayedSignal and sugar.dispatch.DbusSignal

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by sascha_silbe

add classes sugar.dispatch.RelayedSignal and sugar.dispatch.DbusSignal

comment:1 Changed 11 years ago by walter

  • Milestone changed from 0.88 to 0.90

Seems like a win, but pushing to 0.90 as it is late in the release cycle.

comment:2 follow-up: Changed 11 years ago by tomeu

  • Keywords r! added; r? removed

Two comments:

  • can you add a link to the patch that makes use of this class?
  • if we don't have still a use for RelayedSignal I think it would be better to not have it and refactor later. In Sugar we have been favouring simpler code and refactoring when needed.

comment:3 in reply to: ↑ 2 Changed 11 years ago by sascha_silbe

  • Keywords r? added; r! removed

Replying to tomeu:

  • can you add a link to the patch that makes use of this class?

See #1681.

comment:4 Changed 8 years ago by dnarvaez

  • Resolution set to incomplete
  • Status changed from new to closed

If this didn't land for 3 years... And there are no response about reviewer questions.

comment:5 Changed 7 years ago by dnarvaez

  • Milestone 0.90 deleted

Milestone 0.90 deleted

Note: See TracTickets for help on using tickets.