Opened 12 years ago

Closed 9 years ago

Last modified 8 years ago

#1273 closed defect (fixed)

Bookmark dialog has no border

Reported by: erikos Owned by: sayamindu
Priority: Unspecified by Maintainer Milestone:
Component: Read Version: Git as of bugdate
Severity: Major Keywords: olpc-test-passed
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description


Change History (6)

comment:1 Changed 12 years ago by sayamindu

We can't possibly set the dialog window to be fully decorated here, since then the close/maximize/minimize buttons will come up. However, I can set the window manager to draw frames:

diff --git a/readdialog.py b/readdialog.py
index c60d1a0..41cafdc 100644
--- a/readdialog.py
+++ b/readdialog.py
@@ -17,7 +17,6 @@ class BaseReadDialog(gtk.Window):
 
         self.connect('realize', self.__realize_cb)
 
-        self.set_decorated(False)
         self.set_position(gtk.WIN_POS_CENTER_ALWAYS)
         self.set_border_width(style.LINE_WIDTH)
 
@@ -71,6 +70,7 @@ class BaseReadDialog(gtk.Window):
         self._canvas = canvas
 
     def __realize_cb(self, widget):
+        self.window.set_decorations(gtk.gdk.DECOR_BORDER)
         self.window.set_type_hint(gtk.gdk.WINDOW_TYPE_HINT_DIALOG)
         self.window.set_accept_focus(True)
 

Do you think this makes sense ?

comment:2 Changed 10 years ago by godiard

Is not a good idea.

This patch show a border managed by the window manager and open a can of worms (show metacity dialog, etc). I think we need do the same is doing ObjectChooser.

comment:3 Changed 10 years ago by godiard

  • Milestone changed from 0.86 to 0.94

comment:4 Changed 9 years ago by godiard

  • Keywords olpc-test-pending added
  • Milestone changed from 0.94 to 0.96
  • Resolution set to fixed
  • Status changed from new to closed

Actually this is the right solution. Implemented in gtk3 Read.

Fixed in ae580be2b45a7c65705ca1eebe9f543c9fd1b11f

comment:5 Changed 9 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

The bookmark dialog appears to have a border in Read-99/OLPC 12.1.0 os10.

comment:6 Changed 8 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.