#1210 closed defect (fixed)
let the logger do the formatting
Reported by: | sascha_silbe | Owned by: | sascha_silbe |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | |
Component: | Sugar | Version: | Unspecified |
Severity: | Unspecified | Keywords: | r+ |
Cc: | Distribution/OS: | Unspecified | |
Bug Status: | New |
Description
With the attached patch we delegate the string formatting to the logger instead of doing it ourselves.
Advantages:
a) It's more robust: Constructs like 'debug("foo %r bar" % x)' are quite common in our code and will break if x is a tuple. 'debug("foo %r bar", x)' will work regardless of the type of x.
b) formatting only happens if we actually log something.
I haven't measured the impact of b) because a) is much more important to me (happened a lot of times during the object_id => (tree_id, version_id) conversion). At least one project has asked for pylint to flag these occurences and gave performance as a reason for the change, though (so they mave have measured it).
Attachments (1)
Change History (5)
Changed 14 years ago by sascha_silbe
comment:1 Changed 14 years ago by erikos
- Milestone changed from Unspecified by Release Team to 0.86
comment:2 Changed 14 years ago by tomeu
- Keywords r+ added; r? removed
- Owner changed from tomeu to sascha_silbe
- Status changed from new to assigned
Looks good, we should push these changes early in the release cycle, though. Please push, thanks!
comment:3 Changed 14 years ago by sascha_silbe
- Resolution set to fixed
- Status changed from assigned to closed
Pushed, thanks!
let the logger do the formatting