Opened 10 years ago

Closed 9 years ago

#1121 closed defect (fixed)

Write canvas redraw glitch when locking open a secondary toolbar

Reported by: garycmartin Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Write Version: Git as of bugdate
Severity: Unspecified Keywords: r+
Cc: eben, uwog Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

When clicking any of the primary toolbar icons to lock in a secondary toolbar, the top of the Write canvas is not redrawing correctly and shows as a grey strip (see attached screen-shot).

Attachments (2)

Write_toolbar_redraw_glitch.png (41.4 KB) - added by garycmartin 10 years ago.
0001-Let-abiword-change-zoom_percentage-value-before-usin.patch (1.1 KB) - added by alsroot 9 years ago.

Download all attachments as: .zip

Change History (14)

Changed 10 years ago by garycmartin

comment:1 Changed 10 years ago by alsroot

  • Resolution set to fixed
  • Status changed from new to closed

workarond code to redraw entirely abi document on every resize
http://git.sugarlabs.org/projects/write/repos/mainline/commits/a5a033158da70075b995a8ddff1a21d769286b71

its an upstream bug
src/af/xap/gtk/xap_UnixFrameImpl.cpp::XAP_UnixFrameImpl::_fe::do_ZoomUpdate()
doesn't update screen correctly

comment:2 Changed 9 years ago by bernie

  • Cc changed from eben to eben,

This patch has the side effect of resetting the zoom level to 100%, causing text to look very tiny on the XO by default.

After reverting this patch, I can no longer reproduce this bug on F-13 with Write 69.

However, I can still reproduce it on Fedora 11, with the same version of Write and libabiword. So I suspect a gtk, cairo or X11 issue.

comment:3 Changed 9 years ago by bernie

  • Cc uwog added

comment:4 Changed 9 years ago by bernie

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:5 Changed 9 years ago by alsroot

  • Keywords r? added

Tested last patch on os284py.img, works fine

comment:6 Changed 9 years ago by bernie

Tested on F11-0.88 (os297py). Works great.

Please, apply this patch and release a new Write bundle, thanks.

comment:7 Changed 9 years ago by alsroot

  • Owner changed from alsroot to tomeu
  • Status changed from reopened to assigned

comment:8 Changed 9 years ago by tomeu

  • Keywords r+ added; r? removed

Workaround looks good.

comment:9 Changed 9 years ago by bernie

Thanks, I will apply the patch and make a new release.

comment:10 Changed 9 years ago by bernie

  • Resolution set to fixed
  • Status changed from assigned to closed

Done.

comment:11 Changed 9 years ago by erikos

  • Resolution fixed deleted
  • Status changed from closed to reopened

http://bugs.sugarlabs.org/attachment/ticket/1121/0001-Let-abiword-change-zoom_percentage-value-before-usin.patch This patch did never make it into the master branch. We had to bump into it another time.

comment:12 Changed 9 years ago by erikos

  • Resolution set to fixed
  • Status changed from reopened to closed

In version 72.

Note: See TracTickets for help on using tickets.