Read shows "%" zoom submenu label as black on dark background

[greenfeld]

Read-99 shows its "%" zoom submenu/custom control label with black text on a dark background on OLPC 12.1.0 os8.

There are similar tickets on this subject such as #3479.

[erikos]

Good catch, would be great to do something about this.

[greenfeld]

Given this is showing up in more than one activity, is this a sign there is a problem with the core Sugar libraries and/or theme?

Or has no one thought of making sure all Sugar activities could tolerate theme changes before?

[walter]

I submitted a patch in regard to #3479 that addresses this issue (and a similar one for alerts) in Abacus. But it is a change in the default behavior of the Sugar label style. We should really fix it in the toolkit.

[erikos]

diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em
index dce2a58..7ef8448 100644
--- a/gtk3/theme/gtk-widgets.css.em
+++ b/gtk3/theme/gtk-widgets.css.em
@@ -505,6 +505,10 @@ SugarPaletteWindowWidget GtkToolButton .button {
     padding: $(default_padding)px;
 }
 
+.toolbar GtkLabel {
+    color: @white;
+}
+
 .toolbar GtkToolButton .button:prelight,
 SugarPaletteWindowWidget GtkToolButton .button:prelight {
     background-color: @black;

The patch does fix the Read case and Abacus as well.

[godiard]

Thanks erikos

Tested. Works ok and can remove more hardcoded white color in Read activity.

Change component to sugar-artwork.

[erikos]

Great, pushed as: bf8a5d25ddf9d12fc7e2aa4c50ff014ae6dbac7d