Ticket #3558 (closed defect: fixed)

Opened 13 months ago

Last modified 13 months ago

Read shows "%" zoom submenu label as black on dark background

Reported by: greenfeld Owned by: erikos
Priority: Unspecified by Maintainer Milestone: 0.96
Component: sugar-artwork Version: Git as of bugdate
Severity: Unspecified Keywords: 12.1.0, olpc-testing-pending
Cc: Distribution/OS: OLPC
Bug Status: Assigned

Description (last modified by greenfeld) (diff)

Read-99 shows its "%" zoom submenu/custom control label with black text on a dark background on OLPC 12.1.0 os8.

There are similar tickets on this subject such as #3479.

Change History

Changed 13 months ago by greenfeld

  • description modified (diff)

Changed 13 months ago by erikos

  • keywords 12.1.0 added
  • status_field changed from Unconfirmed to Assigned
  • version changed from Unspecified to Git as of bugdate
  • milestone changed from Unspecified by Release Team to 0.96

Good catch, would be great to do something about this.

Changed 13 months ago by greenfeld

Given this is showing up in more than one activity, is this a sign there is a problem with the core Sugar libraries and/or theme?

Or has no one thought of making sure all Sugar activities could tolerate theme changes before?

Changed 13 months ago by walter

I submitted a patch in regard to #3479 that addresses this issue (and a similar one for alerts) in Abacus. But it is a change in the default behavior of the Sugar label style. We should really fix it in the toolkit.

Changed 13 months ago by erikos

  • keywords 12.1.0, patch added; 12.1.0 removed
diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em
index dce2a58..7ef8448 100644
--- a/gtk3/theme/gtk-widgets.css.em
+++ b/gtk3/theme/gtk-widgets.css.em
@@ -505,6 +505,10 @@ SugarPaletteWindowWidget GtkToolButton .button {
     padding: $(default_padding)px;
 }
 
+.toolbar GtkLabel {
+    color: @white;
+}
+
 .toolbar GtkToolButton .button:prelight,
 SugarPaletteWindowWidget GtkToolButton .button:prelight {
     background-color: @black;

The patch does fix the Read case and Abacus as well.

Changed 13 months ago by godiard

  • owner changed from godiard to benzea
  • component changed from Read to sugar-artwork

Thanks erikos

Tested. Works ok and can remove more hardcoded white color in Read activity.

Change component to sugar-artwork.

Changed 13 months ago by erikos

  • keywords olpc-testing-pending added; patch removed
  • owner changed from benzea to erikos
  • status changed from new to assigned

Great, pushed as: bf8a5d25ddf9d12fc7e2aa4c50ff014ae6dbac7d

Changed 13 months ago by erikos

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.