Ticket #3479 (closed defect: fixed)

Opened 14 months ago

Last modified 13 months ago

Abacus puts black text on dark submenu background

Reported by: greenfeld Owned by: walter
Priority: Unspecified by Maintainer Milestone: 0.96
Component: Abacus Version: Unspecified
Severity: Unspecified Keywords: 12.1.0
Cc: manuq Distribution/OS: OLPC
Bug Status: New

Description

Abacus-32 in OLPC 12.1.0 os7 uses Black fonts on top of Sugar's almost-black menu-bar background when customizing an Abacus.

This is hard to read.

Change History

Changed 14 months ago by walter

Hmm. I am not doing anything special re setting the label font color... should be using whatever the default is, which used to be white. Will investigate.

Changed 14 months ago by manuq

  • cc manuq added

Changed 14 months ago by walter

 http://git.sugarlabs.org/abacus/abacus-gtk3/commit/da59709d1ebf892a68866cf4a6e3ac4948672eb4 addresses this issue. But there is a new issue with the alert I added to let the user know that the abacus is loading. Same issue in Browse. We need to fix the style for both Alerts and Labels.

Changed 14 months ago by walter

 http://git.sugarlabs.org/abacus/abacus-gtk3/commit/c53b62316b18792c7c0f20a8f37b91649a854130 is a temporary work-around for the alerts. (Manuq: this same idea should work for Browse as well, but better yet, we should fix alert.py)

Changed 14 months ago by walter

Should be fixed in Version 34.

Changed 14 months ago by erikos

  • keywords 12.1.0 added

There have been a recent fix to the artwork for the color on the alert:  http://git.sugarlabs.org/sugar-artwork/mainline/commit/c90438297b7084aa9699e92d2d8eac9682ce741a which went into 0.96.0. Walter can you test if you still need the workaround for the alert? I did not get to an alert here so far.

Sidenote: with version 32 there is a traceback when clicking on the custom option: "global name 'Custom' is not defined". Might be fixed already in the latest version...

Changed 14 months ago by erikos

  • status_field changed from Unconfirmed to New
  • milestone changed from Unspecified by Release Team to 0.96

Ok, so both workarounds can go away: the alert labes have been fixed, and the label on the sub-toolbar we have a fix that is at least working for me (see #3558).

As well doing a custom abacus seems to work in the latest version.

One remaining issue with Abacus is, that with the new spin-button widget the custom button is drawn off the screen, filed #3563 for that.

Changed 13 months ago by walter

  • status changed from new to closed
  • resolution set to fixed

Fixed in v34 (and in the Sugar style)

Note: See TracTickets for help on using tickets.