Easy way to clear the url entry

[erikos]

In Browse I was looking for an easy way to clear the url entry, so that I can type a new url. In iOS you have a button at the right to do this (screenshot attached). The 'x' button is slightly different than the 'x' for stop loading of a page.

[erikos]

use the 'x' to clear the url entry

[erikos]

use the 'x' to stop loading

[callkalpa]

So we need two separate buttons. One to stop loading and the other to clear the URL box.

[garycmartin]

Just to clarify, the option to clear the url field should only appear when the url input has focus (e.g. you click/tap it to efit, or issue the keyboard shortcut ctrl-L). In the place where the little stop page loading icon would be, should be our standard clear field icon (grey circle with while x inside). Once you press the clear field icon, the field should be blanked and the clear field icon disappear (only to reappear once you start typing some text).

[erikos]

Replying to garycmartin:

Just to clarify, the option to clear the url field should only appear when the url input has focus (e.g. you click/tap it to efit, or issue the keyboard shortcut ctrl-L). In the place where the little stop page loading icon would be, should be our standard clear field icon (grey circle with while x inside). Once you press the clear field icon, the field should be blanked and the clear field icon disappear (only to reappear once you start typing some text).

Correct, that would be the desired behavior in my opinion. And the general behavior is good with you? Should we use similar icons as on iOS (see screenshots)?

[garycmartin]

Replying to erikos:

Replying to garycmartin:

Just to clarify, the option to clear the url field should only appear when the url input has focus (e.g. you click/tap it to efit, or issue the keyboard shortcut ctrl-L). In the place where the little stop page loading icon would be, should be our standard clear field icon (grey circle with while x inside). Once you press the clear field icon, the field should be blanked and the clear field icon disappear (only to reappear once you start typing some text).

Correct, that would be the desired behavior in my opinion. And the general behavior is good with you? Should we use similar icons as on iOS (see screenshots)?

Yes, and the icons are already very similar to the ones iOS used - my only suggestion would be that we consider a square stop icon, to stop a loading page, rather than the current grey x (which we use to close tabs and close control panels).

[manuq]

Proposal new icon for the stop loading button

[manuq]

I attached a proposal for a stop loading button icon with a black square background. If Gary approves, there is a patch sent to the list.

[manuq]

Also see old enhacement proposal in #1511 .

[erikos]

Replying to garycmartin:

Replying to erikos:

Replying to garycmartin:

Just to clarify, the option to clear the url field should only appear when the url input has focus (e.g. you click/tap it to efit, or issue the keyboard shortcut ctrl-L). In the place where the little stop page loading icon would be, should be our standard clear field icon (grey circle with while x inside). Once you press the clear field icon, the field should be blanked and the clear field icon disappear (only to reappear once you start typing some text).

Correct, that would be the desired behavior in my opinion. And the general behavior is good with you? Should we use similar icons as on iOS (see screenshots)?

Yes, and the icons are already very similar to the ones iOS used - my only suggestion would be that we consider a square stop icon, to stop a loading page, rather than the current grey x (which we use to close tabs and close control panels).

Hmm, if you change the stop icon you would need to change the reload one as well, otherwise it looks strange. To me the simple 'x' and 'reload' icon do match nicely together.

As you say, our 'dialog-cancel' icon is already the same as the one in iOS, we can keep that. See #3385 though, for an issue adding that to an entry.

[manuq]

Attached a patch that adds the square background to both icons.

[manuq]

load cancel icon

[garycmartin]

After testing the square based options for browse-dialogue-cancel and browse-view-refresh icons I'd like to reject my suggestion we consider a square stop icon (aka browse-dialogue-cancel). The existing stroke based browse icons are the least intrusive (as they make best use of the space without feeling cramped), and we should use sugar-artwork dialogue-cancel for clearing the url entry (or its equivalent icon fixing the wrong size bug #3385).

[manuq]

Replying to garycmartin:

After testing the square based options for browse-dialogue-cancel and browse-view-refresh icons I'd like to reject my suggestion we consider a square stop icon (aka browse-dialogue-cancel). The existing stroke based browse icons are the least intrusive (as they make best use of the space without feeling cramped), and we should use sugar-artwork dialogue-cancel for clearing the url entry (or its equivalent icon fixing the wrong size bug #3385).

Yeah, fine for me too.

[humitos]

I've just attached a patch with this behaviour. Although I'm not happy with the icon to clear the url.

Manuq and Gary, can you take a look at my patch and suggest a new icon?

[manuq]

Works great humitos. Only exception should be the tabs displaying PDF. They have not editable entries, so the button to clear text should not be displayed for them.

[manuq]

Also we should use the 'dialog-cancel' icon as per Gary comment 11.

[humitos]

v2 - don't show icons on pdf tabs

[manuq]

Found this: the text clear button should dissapear when there is no text in the entry. After you click on it, for example. See the search entries in sugar for reference.

But we can follow up that in another ticket, pushed as af31a44d . Thanks.

[humitos]

Replying to manuq:

Found this: the text clear button should dissapear when there is no text in the entry. After you click on it, for example. See the search entries in sugar for reference.

Followed in #3968