Better error message when a page can not be loaded

[erikos]

At the momet we do get the standard error message. Have the message translated etc.

[manuq]

We need to handle the load-error signal to display our custom page.

 http://webkitgtk.org/reference/webkitgtk/stable/webkitgtk-webkitwebview.html#WebKitWebView-load-error

"By default, if the signal is not handled, the web_view will display a stock error page. You need to handle the signal if you want to provide your own error page."

Epiphany does this in load_error_cb of embed/ephy-web-view.c .

[humitos]

There is a ticket related with this one

 http://dev.laptop.org/ticket/2520

[garycmartin]

Thanks for digging out that old ticket humitos. I do like the design and intent behind the two mockup images from Eben, though the wording for no-network-error would need a little adjustment regarding the reference to mesh, and the black background with white content should be swapped to closer match current designs:

 http://dev.laptop.org/attachment/ticket/2520/activity_browse_no-network-error.png
 http://dev.laptop.org/attachment/ticket/2520/activity_browse_page-not-found-error.png

I'll attach a mockup of the two above cases to this ticket.

[garycmartin]

Just added mockups of the two example Sugar friendly messages. Any more cases of Brows error messages that need work?

[humitos]

Gary: I've just see your last comment. WebKit doesn't make different between being connected to internet or not. It just says: "Cannot resolve hostname (google.com)" and the error code is always "2".

So, we need another way to check if we are connected to the internet or not and make that difference. Any idea?

[garycmartin]

Replying to humitos:

Gary: I've just see your last comment. WebKit doesn't make different between being connected to internet or not. It just says: "Cannot resolve hostname (google.com)" and the error code is always "2".

So, we need another way to check if we are connected to the internet or not and make that difference. Any idea?

Blast, I hoped webkit had some hooks. I had a quick look at using javascript testing navigator.onLine, but that always seems to be reporting that our browser is online (even when it isn't), and most other scripts 'phone home' to their servers to test for internet access (which is not a general enough solution for us). Let me reword the dialogue message and we just go with the one type of message webkit currently provides. Will attach another mockup with the rewording.

[humitos]

Replying to garycmartin:

Let me reword the dialogue message and we just go with the one type of message webkit currently provides. Will attach another mockup with the rewording.

Thanks. I think it's very useful to show the url typed to know if we made some mistake or not.

[garycmartin]

Replying to humitos:

Replying to garycmartin:

Let me reword the dialogue message and we just go with the one type of message webkit currently provides. Will attach another mockup with the rewording.

Thanks. I think it's very useful to show the url typed to know if we made some mistake or not.

I've just added a mockup with updated wording to cover for the error case that webkit provides for. Please keep an eye on how the text layout flows when the URL is long (lots of web sites these days have quite deep URL structures so will be fairly common).

[humitos]

v2

[manuq]

Great, I will push it with the small changes described below, and I have noticed the following things to be solved later:

- the error page doesn't show the faulty url, the url entry is empty (it is displayed if you switch to another tab and go back to the tab with the error page)

- pdf tabs don't display error page when there is no internet connection

- button color is in a slightly different grey tone than sugar buttons

What I've changed:

- converted tabs to spaces in from the error page template

- removed the bottom margin because otherwise the page can scroll unnecessarily:

--- a/data/error_page.tmpl
+++ b/data/error_page.tmpl
@@ -39,7 +39,7 @@
       #container {
           /* we need double percent sign here because
              of Python sustitution */
-         margin: 15%%;
+         margin: 15%% 15%% 0 15%%;
       }
     </style>
   </head>

Pushed as e9915e3d .

[humitos]

These improvements are tracked in #3969. Thanks!