The toolbar height with the gtk3 theme is smaller than in the gtk2 theme

[godiard]

Testing in os5 with the latest rpms. See images attached

[godiard]

Left is terminal with gtk2 theme, right is Read with gtk3 theme

[godiard]

After doing many test I have found than changing:

diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em
index 4323e6e..f9b01da 100644
--- a/gtk3/theme/gtk-widgets.css.em
+++ b/gtk3/theme/gtk-widgets.css.em
@@ -20,7 +20,7 @@ if scaling == "100":
     icon_base = 11
     bullet_size = 9.5
     font_height = 24
-    default_padding = 6
+    default_padding = 7
     toolbutton_padding = 9
 else: # About 72% of the XO size, adjusted so that eg. toolbuttons work
     xo = False

solve this ticket and #3407 !

Can anybody confirm?

[godiard]

Screenshot of Read (gtk3 activity) with the patch aplied in the theme

[manuq]

This shows that in 92 px the height is right

[manuq]

This shows that in 92 px the height is right

[godiard]

Before trying this change, I have tried adding padding to the toolbar. It's possible solve the the toolbar size applying a padding of 3, but the problem is with the lines we use when the subpalette is down; the left, top and right sides of the button are separated of the lines drawn in the subtoolbar.

I couldn't find why the value of 7 is ok, when in the old (gtk2) theme 6 was the value selected. I found many differences, the button had a property inner-border, but apparently is set to 0. In the old theme there are also "fake" definitions as:

    # We fake the default border in the theme
    GtkButton::default-border = { 0, 0, 0, 0 }
    GtkButton::default-outside-border = { 0, 0, 0, 0 }
    GtkButton::image-spacing = $subcell_size

or

style "toolbutton"
{
    xthickness = 0
    ythickness = 0
    GtkButton::inner-border = { $toolbutton_padding,
                                $toolbutton_padding,
                                $toolbutton_padding,
                                $toolbutton_padding }
    GtkWidget::focus-padding = 0

    ...

    engine "sugar" {
        max_radius = 5.0
        fake_padding = $default_padding
    }
}

Another confussing issue is we have a variable toolbutton_padding but is only used to:

BrowseNotebook.notebook tab .button {
    border-radius: $(toolbutton_padding)px;
}

.toolbar GtkToolButton .button,
SugarPaletteWindowWidget SugarRadioToolButton *,
SugarPaletteWindowWidget GtkToolButton .button{
    background-color: transparent;
    border-radius: $(toolbutton_padding)px;
    padding: $(default_padding)px;
}

SugarPaletteWindowWidget SugarRadioToolButton *:active {
    background-color: @button_grey;
    border-radius: $(toolbutton_padding)px;
}

.toolbar GtkToolButton .button:active {
    background-color: @button_grey;
    border-radius: $(toolbutton_padding)px;
}

then should be better rename it to "border_radius"

In the same way, "default_padding" is used in:

.notebook {
    background-color: @selection_grey;
    padding: 0px;
    -GtkNotebook-tab-overlap: -2;
    -GtkNotebook-tab-curvature: $default_padding;
}

.toolbar GtkToolButton .button,
SugarPaletteWindowWidget SugarRadioToolButton *,
SugarPaletteWindowWidget GtkToolButton .button{
    background-color: transparent;
    border-radius: $(toolbutton_padding)px;
    padding: $(default_padding)px;
}

may be we should rename it.

But anyway all this does not explain why the value has not changed in the 75 theme. A rounding issue maybe?

[manuq]

Proposed patch

[manuq]

Image of the GTK2 toolbar for reference

[manuq]

Image of the GTK3 toolbar with the proposed patch applied

[manuq]

Improved patch

[manuq]

The last patch gets the correct toolbar height too, without changing the toolbutton_padding variables, and setting the same -GtkWidget-focus-padding and -GtkWidget-focus-line-width as the gtk2 theme.

[manuq]

The problem with the second patch is that several widgets get a sorrounding line for the active state.

[erikos]

Great work, and excellent explanation in the commit message, please go ahead.

[manuq]

This is a comparison of the current state of gtk3 (Browse) vs. gtk2 (Terminal).

[manuq]

As the comparison above shows we are almost there, the secondary toolbar has 1px vertical border compared to the gtk2 one.

[manuq]

Pushed in ba44df1b and 8645e437 . The secondary toolbar 1px mistery should be fixed later in #4019 .