Artifacts in share buttons

[godiard]

In os5 with the last sugar-artwork/toolkit rpm, the icons in the share toolbar are not displayed ok in a gtk3 activity (Read).

The gtk2 activities are ok, and the same gtk3 activity show the icons ok in my F16 devel env.

[godiard]

The same icon when the mouse is over it

[erikos]

One of the issues here is that in radiotoolbutton we still have code that is using 'do_expose_event' instead of 'do_draw', this has to be ported.

[erikos]

share palette in gtk2

[erikos]

shared palette in gtk2: when shared the buttons become inactive (becasue one can not unshare other than closing the activity)

[erikos]

First part of the issue:

The white square which can be seen in the sharing palette instead of the home view icon is because the background-color for a widget in the active state is set to white in the theme by default:  http://git.sugarlabs.org/sugar-artwork/mainline/blobs/master/gtk3/theme/gtk-widgets.css.em#line123 The widget is in the active state at that moment. We have to see now if we need that gloabl background setting and what uses it, maybe it can be more specialized.

[garnacho]

Partial fix, improve theming of share buttons

[garnacho]

The attached patch improves the theming color wise (I don't know of any gtk2 activity to compare it with though), but triggers some weird resizing of the palette window. I've yet to investigate where do those come from, it looks like either:
- some css rules specificity bug (there don't seem to be rules that should mess with padding/margin)
- something in the code triggering a queue_resize() with strange values, the bigger rectangle over the active&hovered item might stretch things, and isn't drawn by the GtkRadioToolButton child itself

[garnacho]

Doh! I completely oversaw a cluster of rules that could override certain values, I'm attaching another patch, which coincidentally fixes  http://bugs.sugarlabs.org/ticket/3590 as well

[garnacho]

patch

[erikos]

Patch to fix the artifacts in teh share button

[erikos]

I pushed the patch now with a more detailed description as:  http://git.sugarlabs.org/sugar-artwork/mainline/commit/54ef96860a93eb5c95ea019c12cd4dc388117398 after I got green testing light from Gonzalo, will be in 0.96.3.

I think the issue described here is fixed now and we have the same appearance as with the old toolkit. As an enhancement, we might want to highlight the neighborhood icon when hovering over it:

SugarPaletteWindowWidget SugarRadioToolButton *:hover {
    background-color: @button_grey;                                                                                                                                                      
    border-radius: $(toolbutton_padding)px;                                                                                                                                           
}

[greenfeld]

I can exactly reproduce the problem shown in the Captura_share_button_gtk3.png and Captura_share_button_gtk_hover.png files, so this does not seem to be fixed.

[greenfeld]

Actually I take that back; may not be in the build yet as of os11.

[greenfeld]

This still does not seem to be fixed in 12.1.0 os13.

[erikos]

Works fine for me in os13, which has artwork-0.93 which has the fix.

[greenfeld]

The fix is in 12.1.0 os14/os15, but according to  http://build.laptop.org/12.1.0/os13/xo-1.5/21013o1.packages.txt os13 still had sugar-artwork-0.96.2.

[erikos]

Ok, I see now - I checked on the 1.75 where the 0.93 release was available on the 1.5 you are right it was still 0.92 in the os13 build. An issue introduced by the infrastructural differences.