Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#957 closed defect (obsolete)

Logs do not get updated

Reported by: erikos Owned by: wadeb
Priority: Unspecified by Maintainer Milestone:
Component: Log Version: 0.84.x
Severity: Critical Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

Solution: Hold a reference to the monitors so they don't get disposed

diff --git a/logviewer.py b/logviewer.py
index c4e051f..2da0f08 100644
--- a/logviewer.py
+++ b/logviewer.py
@@ -44,6 +44,7 @@ class MultiLogView(gtk.HPaned):
         
         self.paths = paths
         self.extra_files = extra_files
+        self._gio_monitors = []
 
         self.active_log = None
         self.logs = {}
@@ -145,10 +146,12 @@ class MultiLogView(gtk.HPaned):
         for p in self.paths:
             monitor = gio.File(p).monitor_directory()
             monitor.connect('changed', self._log_file_changed_cb)
+            self._gio_monitors.append(monitor)
 
         for f in self.extra_files:
             monitor = gio.File(f).monitor_file()
             monitor.connect('changed', self._log_file_changed_cb)
+            self._gio_monitors.append(monitor)
 
     def _log_file_changed_cb(self, monitor, file, other_file, event):
         logfile = file.get_basename()

The pygobject had a change late in the 2.16 cycle why this fix is needed.

Change History (3)

comment:1 Changed 12 years ago by alsroot

  • Resolution set to obsolete
  • Status changed from new to closed

Log was switched to gnomevfs and looks like it works w/o this patch

comment:2 Changed 12 years ago by alsroot

oops, its already applied

comment:3 Changed 8 years ago by dnarvaez

  • Milestone 0.86 deleted

Milestone 0.86 deleted

Note: See TracTickets for help on using tickets.