#515 closed defect (fixed)
Factorial and boolean equality not working
| Reported by: | sascha_silbe | Owned by: | chasedspeed |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | Calculate | Version: | Git as of bugdate |
| Severity: | Major | Keywords: | |
| Cc: | Distribution/OS: | Unspecified | |
| Bug Status: | New |
Description
Using the Factorial button (x!, in Algebra) will insert an exclamation mark, which leads to a Parse Error on evaluation.
Change History (9)
comment:1 Changed 15 years ago by sascha_silbe
comment:2 Changed 15 years ago by wadeb
- Owner changed from wadeb to rwh
- Status changed from new to assigned
comment:3 Changed 15 years ago by rwh
- Resolution set to fixed
- Status changed from assigned to closed
Fixed in git. The button now inserts "fac()". Unfortunately it is quite tricky to let the new parser understand that "5!" means 5 factorial, so not doing that.
comment:4 Changed 15 years ago by sascha_silbe
- Resolution fixed deleted
- Status changed from closed to reopened
- Summary changed from Factorial not working to Factorial and boolean equality not working
Factorial and boolean inequality are working fine now (thanks!), but boolean equality is still broken, thus reopening.
comment:5 Changed 15 years ago by chasedspeed
- Owner changed from rwh to chasedspeed
- Status changed from reopened to assigned
comment:6 Changed 14 years ago by tomeu
- Milestone changed from Unspecified by Release Team to 0.86
- Priority changed from Unspecified by Maintainer to Normal
- Severity changed from Unspecified to Major
comment:7 Changed 14 years ago by sascha_silbe
- Bug Status changed from Unconfimed to New
Equality is working fine with numbers now, but the boolean constants True and False don't work. Since doing a calculation (or more specifically a test) that returns a boolean value and pressing a boolean operator will insert the last result (i.e. True or False) in the expression field, I assume that it's supposed to work, thus still leaving this bug open.
comment:8 Changed 13 years ago by garycmartin
- Resolution set to fixed
- Status changed from assigned to closed
Reinier fixed this (True/False boolean constants) in commit 569b1093, should be in Calculate-32 once released.
Same for equality (=) in Boolean. Inequality (!=) is broken as well (traceback, no visual feedback), opening a new bug for that.