#3849 closed defect (fixed)
RadioToolButton is too big if the icon is not set in the constructor
Reported by: | manuq | Owned by: | godiard |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | |
Component: | Sugar | Version: | Unspecified |
Severity: | Unspecified | Keywords: | theme |
Cc: | godiard, erikos | Distribution/OS: | Unspecified |
Bug Status: | Unconfirmed |
Description
And makes the toolbar height too tall as a consequence.
Found in Paint GTK+3 port, currently mainline. This change in the toolbuttons.py testcase shows the issue:
diff --git a/tests/graphics/toolbuttons.py b/tests/graphics/toolbuttons.py index c4c8cf8..738ee75 100644 --- a/tests/graphics/toolbuttons.py +++ b/tests/graphics/toolbuttons.py @@ -19,7 +19,8 @@ toolbar_box = ToolbarBox() vbox.pack_start(toolbar_box, False, False, 0) toolbar_box.show() -radial_button = RadioToolButton(named_icon='view-radial') +radial_button = RadioToolButton() +radial_button.props.icon_name = 'view-radial' toolbar_box.toolbar.insert(radial_button, -1) radial_button.show()
Change History (7)
comment:1 Changed 11 years ago by godiard
- Owner changed from erikos to godiard
- Status changed from new to assigned
comment:2 Changed 11 years ago by manuq
comment:3 Changed 11 years ago by godiard
I fixed the issue in Paint activity, but probably will be good add the the fix in sugar-toolkit [1] to avoid the same problem in other activities.
Anyway, this is only with gtk3 activities, then may be can be solved at porting time.
A annoying issue with our api in toolbutton, radiotoolbutton, toggletoolbutton, are theselittle inconsistencies.
[1] http://lists.sugarlabs.org/archive/sugar-devel/2012-September/039624.html
comment:4 Changed 11 years ago by godiard
- Cc erikos added
comment:5 Changed 11 years ago by godiard
- Resolution set to fixed
- Status changed from assigned to closed
Already solved in sugar-tookit-gtk3
comment:6 Changed 10 years ago by dnarvaez
- Component changed from sugar-toolkit-gtk3 to Sugar
Note: See
TracTickets for help on using
tickets.
Using 'named_icon' property does work:
So the "bug if icon is not set in the constructor" phrase is false. However our API changed. Maybe the activities should change to the new API instead?