Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#3669 closed defect (fixed)

image scaling broken in Labyrinth (mapa metales)

Reported by: walter Owned by: manuq
Priority: Unspecified by Maintainer Milestone:
Component: Labyrinth Version: Git as of bugdate
Severity: Unspecified Keywords: 12.1.0, patch, olpc-test-passed
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Line 126 of ImageThought.py is passing float values to simple_scale.

a simple patch of casting the floats to ints will fix the problem.

self.pic = self.orig_pic.scale_simple(int(pic_w), int(pic_h), scale)

Version 12 running on 11.3.1

Change History (5)

comment:1 Changed 7 years ago by garycmartin

  • Owner changed from garycmartin to manuq
  • Status changed from new to assigned

comment:2 Changed 7 years ago by manuq

  • Keywords 12.1.0 patch added
  • Milestone changed from Unspecified by Release Team to 0.96
  • Resolution set to fixed
  • Status changed from assigned to closed

Seen in 12.1.0 too.

TestCase:

  • start Labyrinth, add an image node
  • try to resize the node, activity hangs

Thanks for the patch, tested, reviewed, and pushed as: 2723459fffc670bcf23e79dc1558974c9e973dbc .

comment:3 Changed 7 years ago by manuq

  • Keywords olpc-test-pending added

comment:4 Changed 7 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

Image scaling works in 12.1.0 os16/Labyrith-12.1.

comment:5 Changed 6 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.