Opened 11 years ago

Closed 8 years ago

#3450 closed defect (fixed)

Activity.__init__(..., create_jobject=False) broken

Reported by: sascha_silbe Owned by: erikos
Priority: Normal Milestone: Unspecified
Component: Sugar Version: 0.92.x
Severity: Major Keywords: dx3
Cc: Distribution/OS:
Bug Status: Unconfirmed

Description

An Activity that doesn't have any useful state to save in the Journal and passes create_jobject=False to sugar.activity.activity.Activity.__init__() is bound to fail since Sugar 0.92.4 as ​6b675ed resp. ​0269f819 introduced unconditional accessing of self._jobject:

class Activity(Window, gtk.Container):
[...]
    def __init__(self, handle, create_jobject=True):
[...]
        self.set_title(self._jobject.metadata['title'])

Some later patches have introduced even more unconditional accessing of self._jobject.

This is a regression and should be fixed in both sugar-toolkit-gtk3 and sugar-toolkit, including the (maintained) stable branches.

Change History (5)

comment:1 Changed 10 years ago by dnarvaez

  • Component changed from sugar-toolkit to Sugar

comment:2 Changed 9 years ago by walter

  • Priority changed from Unspecified by Maintainer to Normal

comment:3 Changed 8 years ago by godiard

The solution here probably is deprecate the create_jobject parameter and ignore it. But we need a decision about this.

comment:5 Changed 8 years ago by tch

  • Resolution set to fixed
  • Status changed from new to closed

Closed in ​https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/257

Note: See TracTickets for help on using tickets.