'dialog-cancel' icon has not the correct size when inside a gtk entry

[erikos]

Steps to reproduce:

• type something into the search field in the Home view

---> the 'dialog-cancel' icon to clear the field is too small

• open Browse/Read and search a string in the page

---> the 'dialog-cancel' icon to clear the field is too big

[erikos]

Still the case in os8. Seen as well issues with icons in Fedora beta (e.g. reload icon in url entry which is drawn to low).

[humitos]

I think this is not related with browser. In fact, I think that it's related with sugar3.graphics.iconentry.IconEntry class because Browse just used it.

This is the relevant part of IconEntry class:

def show_clear_button(self):
    if not self._clear_shown:
        self.set_icon_from_name(ICON_ENTRY_SECONDARY,
                                'dialog-cancel')
        self._clear_shown = True

[erikos]

This is as well an issue in Read.

I changed the icon from 'dialog-cancel' to 'system-search' in ​http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/blobs/master/src/sugar3/graphics/iconentry.py#line76 and the icon size is correct. So the issue seem to be in the icon itself.

Another example of this icon behaving strange is the serach in the home view. The icon is too small there.

[erikos]

I remember that we did an dialog-cancel icon for Browse at one point, as far as I remember because we did not get the sizing in the entry right: ​http://git.sugarlabs.org/browse/mainline/blobs/master/icons/browse-dialog-cancel.svg

'dialog-ok' has the same issue. Both are larger than 'system-search' for example and in the entry they probably can not use the full size and scale badly (too small or too big).

Gary, any suggestions from your side?