Opened 12 years ago

Closed 11 years ago

Last modified 8 years ago

#279 closed defect (fixed)

removable device appears without any icon on it

Reported by: tomeu Owned by: benzea
Priority: High Milestone:
Component: Sugar Version: 0.83.x
Severity: Blocker Keywords: sugar-love, r-
Cc: garycmartin Distribution/OS: Ubuntu
Bug Status: Assigned

Description

sugar tries to use 'drive-harddisk' and 'drive' but no icon with those names are in sugar-artwork

Attachments (2)

drive-harddisk.svg (1.3 KB) - added by garycmartin 12 years ago.
Here's an image for drive-harddisk
drive-harddisk.2.svg (1.2 KB) - added by eben 12 years ago.

Download all attachments as: .zip

Change History (22)

comment:1 Changed 12 years ago by tomeu

  • Owner changed from tomeu to eben
  • Status changed from new to assigned

Added some dummy icons that currently are the same as the usb stick icon. Would be nice to have proper icons for it.

http://git.sugarlabs.org/projects/sugar-artwork/repos/mainline/commits/9e9efd5a5c

Eben, could you look at it?

comment:2 follow-up: Changed 12 years ago by tomeu

  • Cc garycmartin added

Or Gary, as he has started doing some awesome icons already ;)

comment:3 in reply to: ↑ 2 Changed 12 years ago by garycmartin

  • Owner changed from eben to garycmartin

Replying to tomeu:

Or Gary, as he has started doing some awesome icons already ;)

Sure, I'll take a shot if Eben's time is thin :-) Any description of what's different between a drive-harddisk and drive? Is drive CD, or other disk based media? I'll get on with drive-harddisk for now.

comment:4 Changed 12 years ago by erikos

So GNOME has these three:

http://commons.wikimedia.org/wiki/File:Gnome-drive-harddisk.svg

http://commons.wikimedia.org/wiki/File:Gnome-drive-removable-media.svg

http://commons.wikimedia.org/wiki/File:Gnome-drive-optical.svg

In the Fedora Theme there are some more differentiations - for example there is a drive-harddisk-usb with a usb-icon badge. Not sure how detailed we need to be here.

Changed 12 years ago by garycmartin

Here's an image for drive-harddisk

comment:5 follow-up: Changed 12 years ago by garycmartin

I'll take a stab at an image for 'drive' if someone can point me in the right direction. It's a bit of a generic concept and we already have icons for removable media disks/cds (media-disk.svg). Does any one have an example device that would want to be shown as a 'drive' icon, and is not a USB stick, hard-disk, or removable disk media?

comment:6 Changed 12 years ago by walter

  • Bug Status changed from Unconfimed to Assigned

comment:7 in reply to: ↑ 5 Changed 12 years ago by tomeu

Replying to garycmartin:

I'll take a stab at an image for 'drive' if someone can point me in the right direction. It's a bit of a generic concept and we already have icons for removable media disks/cds (media-disk.svg). Does any one have an example device that would want to be shown as a 'drive' icon, and is not a USB stick, hard-disk, or removable disk media?

Unfortunately not. This icon will be displayed when we fail to better identify the device, so something close to what is most often used may be the best. So maybe just copy the usb stick?

I think most of our users won't know how a conventional hard disk looks.

comment:8 Changed 12 years ago by garycmartin

Sounds reasonable, a new image can always be added in the future when we know what it's common use is – I did have a scrounge about for ideas, but best I could get to was really just an elongated rectangle with a couple of feet bumps, some parallel lines on the front and a dot for a led – not inspiring.

Changed 12 years ago by eben

comment:9 Changed 12 years ago by eben

  • Owner changed from garycmartin to tomeu

Gary beat me to it, but I've had this icon floating around for quite a while. I'm sorry I didn't get the chance to attach it sooner. It's similar in concept, but a bit simpler in keeping with Sugar's reductionist aesthetic.

comment:10 Changed 12 years ago by homunq

  • Keywords sugar-love added

comment:11 Changed 12 years ago by erikos

  • Keywords r? added
  • Milestone changed from 0.84 to 0.86

comment:12 follow-up: Changed 12 years ago by tomeu

  • Keywords r- added; r? removed

I'm a bit unsure of this, I don't think that a representation of the internals of a hard drive is going to help many Sugar users. I'm thinking that we may stay with the usb stick as a default because in some cases we'll be failing to recognize a usb stick as such. Do people agree?

comment:13 in reply to: ↑ 12 ; follow-up: Changed 12 years ago by garycmartin

Replying to tomeu:

I'm a bit unsure of this, I don't think that a representation of the internals of a hard drive is going to help many Sugar users. I'm thinking that we may stay with the usb stick as a default because in some cases we'll be failing to recognize a usb stick as such. Do people agree?

Tomeu, hey you were the one that wanted a 'proper' HD icon for it! :-b But FWIW I don't have a strong opinion if there a going to be failed usb stick detection cases getting shown with the wrong icon – though of course I do love my little HD icon lots ;-)

comment:15 in reply to: ↑ 13 Changed 12 years ago by tomeu

Replying to garycmartin:

Replying to tomeu:

I'm a bit unsure of this, I don't think that a representation of the internals of a hard drive is going to help many Sugar users. I'm thinking that we may stay with the usb stick as a default because in some cases we'll be failing to recognize a usb stick as such. Do people agree?

Tomeu, hey you were the one that wanted a 'proper' HD icon for it! :-b But FWIW I don't have a strong opinion if there a going to be failed usb stick detection cases getting shown with the wrong icon – though of course I do love my little HD icon lots ;-)

Yeah, it's just that I have noticed that in all cases when it tried to use the hard disk icon, it was actually a pen drive. That's whay I'm leaning now towards leaving it as-is, sorry for the confusion and wasted work :(

comment:16 Changed 11 years ago by alsroot

  • Severity changed from Major to Blocker

comment:17 Changed 11 years ago by alsroot

  • Component changed from sugar to sugar-artwork

After attaching usb/dvd, I got

WARNING root: No icon with the name media was found in the theme.

So, looks like we don't have media.svg in sugar-artwork

comment:18 Changed 11 years ago by alsroot

  • Owner changed from tomeu to benzea
tomeu │ alsroot: guess so, I think we should use the usb stick one in these cases
tomeu │ alsroot: because most of the time will be those
tomeu │ alsroot: and also because we haven't been able to find a meaningful representation of an external hard disk

comment:20 Changed 11 years ago by benzea

  • Resolution set to fixed
  • Status changed from assigned to closed

I am closing this now (please reopen or open a new bug if anyone thinks this should be better).

I have done two changes:

  • Use a CD-ROM icon for media-optical (which we already had in media-disk.svg)
  • Use the usb-key icon for media.svg (ie. as a fallback if no other icon has been found)

comment:21 Changed 8 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:22 Changed 8 years ago by dnarvaez

  • Milestone 0.86 deleted

Milestone 0.86 deleted

Note: See TracTickets for help on using tickets.