Opened 10 years ago

Closed 10 years ago

#2228 closed enhancement (fixed)

add new telepathy dependencies to sugar-jhbuild

Reported by: tomeu Owned by: sascha_silbe
Priority: Urgent Milestone:
Component: sugar-jhbuild Version: Git as of bugdate
Severity: Blocker Keywords:
Cc: Distribution/OS:
Bug Status: New

Description

For 0.90, we are going to depend on versions of the telepathy stack that aren't still packaged in distros.

http://wiki.sugarlabs.org/go/0.90/Notes#Dependencies

Attachments (1)

0001-Update-the-versions-of-our-telepathy-dependencies-an.patch (9.1 KB) - added by tomeu 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by tomeu

  • Keywords r? added

comment:2 Changed 10 years ago by erikos

The following packages I had to install on F13 to build tp-gabble (as extra deps):
sqlite-devel, libnice-devel, libuuid-devel

The patch does work fine for me!

comment:3 Changed 10 years ago by tomeu

Added those new deps

comment:4 Changed 10 years ago by bernie

Fedora 14 already has all the required telepathy packages, they should not be built from source.

comment:5 Changed 10 years ago by sascha_silbe

  • Bug Status changed from Unconfirmed to New
  • Distribution/OS Unspecified deleted
  • Keywords r? removed
  • Milestone Unspecified by Release Team deleted
  • Priority changed from Unspecified by Maintainer to Urgent
  • Severity changed from Unspecified to Blocker
  • Version changed from Unspecified to Git as of bugdate

Thanks for working on this! Unfortunately there are a few issues with the patch:

--- a/config/modulesets/glucose-external-0.84.modules
+++ b/config/modulesets/glucose-external-0.84.modules
@@ -98,6 +98,9 @@
       <dep package="telepathy-glib"/>
       <dep package="dbus-glib"/>
       <dep package="libsoup"/>
+      <dep package="sqlite3"/>
+      <dep package="libuuid"/>
+      <dep package="libnice"/>

You add source dependencies, but no build recipes for them. I suppose you wanted to add system (distro) dependencies instead. For that you'll need to modify the same files you removed telepathy-* from and use the exact package names for the specific distribution, including checking that the version shipped by the distribution suffices for building Telepathy.

+        # Make Mission Control 5 use our accounts dir
+        accounts_dir = os.path.join(os.path.expanduser('~/.sugar'),
+                                    os.environ.get('SUGAR_PROFILE', 'default'),
+                                    'accounts')
+        os.environ.setdefault('MC_ACCOUNT_DIR', accounts_dir)

That should probably rather go into the sugar script, not sugar-jhbuild.

Have you tried building Telepathy (using your patch) on all supported distros?

Please post the improved patch on sugar-devel, that makes it much easier for me to track and review it.

comment:6 Changed 10 years ago by sascha_silbe

  • Resolution set to fixed
  • Status changed from new to closed

Got pushed as 99bd3a2.

Note: See TracTickets for help on using tickets.