Logout for Sugar

[sayamindu]

Continuing from ​http://dev.laptop.org/ticket/8141
The attached patch tries to check for GDM, and shows the log out option only if the user has logged in via GDM (so it won't be shown in an XO or in sugar-jhbuild)

We also need a better icon for this.

[alsroot]

what about reverting if - check if we are on non-XO machine ?

[sayamindu]

Checking for XO only hardware is an option as well - but what if someone decides to use it, in say a classmate, but in the same form as in the XO ?

[alsroot]

Replying to sayamindu:

Checking for XO only hardware is an option as well - but what if someone decides to use it, in say a classmate, but in the same form as in the XO ?

where is a difference between classmate and XO is case of having 'Logout' button :)

[alsroot]

another situation: login from kdm/xdm/etc

[sayamindu]

The problem that I see is, if someone decides not to use GDM in the classmate, and say, wants the user to directly log in (just like what happens in a XO), in that case, the log-out button becomes unnecessary.
The point that I want to make is that the logout button should appear in all cases where you have a login manager running (and I agree with you that it needs to check for KDM/XDM as well).

[sayamindu]

Updated patch, with support for KDM

[erikos]

<marcopg> unmadindu: not sure "running under a dm" is a good logic
<marcopg> unmadindu: soas runs under a dm and it's single user
<unmadindu> marcopg: hmm - any other ideas ?
<marcopg> I don't know if we can make it automatic
<marcopg> maybe we should enable by default and have single user distro patch some kind of config
<marcopg> not sure
<unmadindu> marcopg: but do you have to log in in soas ?
<marcopg> unmadindu: no it does auto-login
<unmadindu> ok..
<unmadindu> dunno if we can detect auto-login - but it is becoming too complicated :(
<marcopg> autodetecting seems pretty much impossible to me

we added the logout option now, and systems where we have a direct login must patch it out for now.

[garycmartin]

Testing on XO-1 hardware with joyride 2631, the Logout option is showing in the XO home palette; not sure if this is intentional. The item does seem to correctly logout and back into the Sugar UI (as if you hit atl-ctrl-erase).

[marcopg]

I'd suggest to make this a gconf preference, so that it can be easily tweaked by distributors. For Fedora spins, for example, we can set the preference from the kickstart.

[sayamindu]

Attached is a patch to do this via GConf. There are two issues involved here:

a) Do we listen for changes to this key ? (we do not expose this setting in the UI anywhere, and no one would probably change it on their own, except for distro makers)

b) We are breaking string freeze. Since this is not a typical user visible string, I suggest that we leave both as blank and add them during the next release cycle.

[sayamindu]

GConf support

[tomeu]

Replying to sayamindu:

Attached is a patch to do this via GConf. There are two issues involved here:

a) Do we listen for changes to this key ? (we do not expose this setting in the UI anywhere, and no one would probably change it on their own, except for distro makers)

Don't think it's needed.

b) We are breaking string freeze. Since this is not a typical user visible string, I suggest that we leave both as blank and add them during the next release cycle.

Yup, agreed.

r+

[sayamindu]

Strings commented out.

[tomeu]

Pushed as ​http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/172f0de2

[godiard]

Milestone 0.84 deleted