'My Settings' overflows on the right

[timclicks]

There are five columns in the 'My Settings' dialogue. This creates a messy overflow on the right on small screens, such as the XO-1.

Changing the _MAX_COLUMNS variable to 4 avoids this problem.

[timclicks]

patch

[bernie]

I think this patch is very useful.

Reviewed-by: Bernie Innocenti <bernie@…>

[tomeu]

I'm a bit concerned about this being an improvement on the XO screen but a regression in other screen sizes. Could we check with the initial committer? git blame says Simon.

[timclicks]

I forgot to mention earlier that I've also tested it in larger screen sizes, e.g. my 15.6' monitor. Each of the icons scale nicely.

[erikos]

This code has always been stupid - fixed sizes meant to break :/ One could even argue that changing it to 3 looks better in many cases. I would like to see a real fix of the issue.

[timclicks]

To an extent, I agree. However, I would prefer that the first viable workable solution (this change) were implemeted, and a new ticket raised that problem. Admittedly, this is a hack - but so is the current situation. I don't see why an easy change that makes a big difference to users is being held back.

Waiting for the perfect solution every time defeats the purpose of iterative development.

[godiard]

Closing as fixed