Opened 13 years ago
Closed 10 years ago
#1996 closed defect (fixed)
'My Settings' overflows on the right
Reported by: | timclicks | Owned by: | timclicks |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | Unspecified |
Component: | Sugar | Version: | Unspecified |
Severity: | Minor | Keywords: | r! |
Cc: | Distribution/OS: | Unspecified | |
Bug Status: | Unconfirmed |
Description
There are five columns in the 'My Settings' dialogue. This creates a messy overflow on the right on small screens, such as the XO-1.
Changing the _MAX_COLUMNS variable to 4 avoids this problem.
Attachments (1)
Change History (8)
Changed 13 years ago by timclicks
comment:1 Changed 13 years ago by timclicks
- Summary changed from 'My Settings' dialogue to 'My Settings' overflows on the right
comment:2 Changed 13 years ago by bernie
I think this patch is very useful.
Reviewed-by: Bernie Innocenti <bernie@…>
comment:3 Changed 13 years ago by tomeu
- Keywords r! added; r? removed
I'm a bit concerned about this being an improvement on the XO screen but a regression in other screen sizes. Could we check with the initial committer? git blame says Simon.
comment:4 Changed 13 years ago by timclicks
I forgot to mention earlier that I've also tested it in larger screen sizes, e.g. my 15.6' monitor. Each of the icons scale nicely.
comment:5 Changed 13 years ago by erikos
This code has always been stupid - fixed sizes meant to break :/ One could even argue that changing it to 3 looks better in many cases. I would like to see a real fix of the issue.
comment:6 Changed 13 years ago by timclicks
To an extent, I agree. However, I would prefer that the first viable workable solution (this change) were implemeted, and a new ticket raised that problem. Admittedly, this is a hack - but so is the current situation. I don't see why an easy change that makes a big difference to users is being held back.
Waiting for the perfect solution every time defeats the purpose of iterative development.
comment:7 Changed 10 years ago by godiard
- Resolution set to fixed
- Status changed from new to closed
Closing as fixed
patch