Opened 11 years ago

Closed 11 years ago

#1749 closed defect (obsolete)

mark legacy clients as valid

Reported by: sascha_silbe Owned by: sascha_silbe
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: sugar-presence-service Version: Git as of bugdate
Severity: Major Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

From src/buddy.py:

            # Validity starts off False, and becomes True when the buddy
            # either has, or has tried and failed to get, a color, a nick
            # and a key.

Currently the "has tried and failed to get" part isn't true because get_properties() doesn't tell Buddy about the failed attempt. The attached patch fixes that.
Impact: Legacy (i.e. non-Sugar) clients that are in the users Jabber roster (either via shared roster or added manually outside of Sugar) and are online will be shown in the Neighborhood (and in the groups view once added as friend). Currently they are shown in the owners color, but that's a separate bug.

Attachments (1)

1749.patch (2.0 KB) - added by sascha_silbe 11 years ago.
mark legacy clients as valid

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by sascha_silbe

mark legacy clients as valid

comment:1 in reply to: ↑ description Changed 11 years ago by sascha_silbe

Replying to sascha_silbe:

Currently they are shown in the owners color, but that's a separate bug.

This is tracked as #1750 now.

comment:2 Changed 11 years ago by sascha_silbe

  • Keywords r? removed
  • Resolution set to obsolete
  • Status changed from new to closed

The whole presence stuff will be rewritten from scratch for 0.90, so no use for these patches anymore.

Note: See TracTickets for help on using tickets.