Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#1514 closed defect (fixed)

FoodForce2 Activity has malformed python files

Reported by: mikus Owned by: garycmartin
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: ActivityTeam Version: 0.84.x
Severity: Unspecified Keywords:
Cc: mikus@… Distribution/OS: OLPC
Bug Status: Unconfirmed

Description

Run 'file !FoodForce2.activity/*.py' and look at the output.

There are files there that do not have proper line-endings for Linux Python. [Some have line-endings left by a Windows editor; some I can't figure out.]


I found this when the !FoodForce2-1 Activity would not launch on an XO-1.5 system -- some of the python files (e.g. load_images.py) had been written-over by binary garbage (those files were correct before the launch of !FoodForce2 was invoked), which in turn caused a Python error when it tried to execute (i.e., interpret) the now-garbage files.

[I was able to bypass the over-writing_with_binary_garbage problem by setting all the .py files in !FoodForce2.activities to read-only.]

I do not know what caused this improper over-writing with binary garbage -- but cleaning up the form of the Python files should be the first step towards fixing the failure-to-launch problem I experienced on the XO-1.5

Change History (6)

comment:1 follow-up: Changed 12 years ago by RafaelOrtiz

FoodForce2 works for me on an X0-1.5 os32 enviroment

comment:2 in reply to: ↑ 1 Changed 12 years ago by mikus

Replying to RafaelOrtiz:

!FoodForce2 works for me on an X0-1.5 os32 enviroment

!FoodForce2 not working for me on an XO-1.5 os32 envoronment appears to have been my own fault.

I normally run builds with the package 'python-psyco' installed. I removed that package from my XO-1.5 os32 system, and !FoodForce2 now launched successfully.

My original description for #1514 was "activity has malformed python files". I still think that is true.

comment:3 follow-up: Changed 12 years ago by RafaelOrtiz

mikus
doing 'file FoodForce2.activity/*.py' shows no estrange things..

this is from a fresh install of ASLO.

comment:4 in reply to: ↑ 3 Changed 12 years ago by mikus

Replying to RafaelOrtiz:

mikus
doing 'file !FoodForce2.activity/*.py' shows no estrange things..

This is the output from my 'file */py':

 activity.py:           ASCII Java program text
 chat.py:               a python\015 script text executable
 defaultStyle.py:       ASCII Java program text
 display_panel.py:      ASCII Java program text
 Exceptions.py:         a python\015#\015#   Author : Mohit Tan script text executable
 !Foodforce2.py:         a python script text executable
 game_events.py:        a python script text executable
 game_sharing.py:       ASCII Java program text, with CRLF line terminators
 gui_buttons.py:        a python script text executable
 gui.py:                ASCII Java program text, with CR line terminators
 initialize.py:         ASCII Java program text
 level_change.py:       ASCII Java program text, with CRLF line terminators
 load_images.py:        a python script text executable
 model.py:              a python script text executable
 natural_calamities.py: a python script text executable
 olpc-setup.py:         a python script text executable
 proceduralFlow.py:     a python\015 script text executable
 run.py:                a python script text executable
 texts.py:              a python\015#\015#   Author : Mohit Tan script text executable
 threades.py:           a python script text executable
 olpcgames/activity.py:      a python script text executable
 olpcgames/buildmanifest.py: a python script text executable
 olpcgames/_cairoimage.py:   a python script text executable
 olpcgames/camera.py:        a python script text executable
 olpcgames/canvas.py:        a python script text executable
 olpcgames/dbusproxy.py:     a python script text executable
 olpcgames/eventwrap.py:     a python script text executable
 olpcgames/gtkEvent.py:      a python script text executable
 olpcgames/_gtkmain.py:      a python script text executable
 olpcgames/__init__.py:      a python script text executable
 olpcgames/mesh.py:          troff or preprocessor input text
 olpcgames/pangofont.py:     a python script text executable
 olpcgames/pausescreen.py:   a python script text executable
 olpcgames/svgsprite.py:     a python script text executable
 olpcgames/textsprite.py:    a python script text executable
 olpcgames/util.py:          a python script text executable
 olpcgames/_version.py:      a python script text executable
 olpcgames/video.py:         a python script text executable
 olpcgames/data/__init__.py:     a python script text executable
 olpcgames/data/sleeping_svg.py: FORTRAN program

I'd be happier if they were all plain "python script text executable".

I did not install !FoodForce2 through the Journal, but with 'sugar-install-bundle'.

comment:5 follow-up: Changed 11 years ago by MohitTaneja

  • Resolution set to fixed
  • Status changed from new to closed

Mikus,

Can you please check this with version 4 of FoodForce2. I have removed the issues with line endings in it.

Regards,
Mohit

comment:6 in reply to: ↑ 5 Changed 11 years ago by mikus

Replying to MohitTaneja:

Mikus,

Can you please check this with version 4 of FoodForce2. I have removed the issues with line endings in it.

In terms of me being able to launch version 4 of FoorDorce2 on the XO-1.5 - for me that works.

Note: See TracTickets for help on using tickets.