Opened 13 years ago

Closed 10 years ago

Last modified 10 years ago

#1395 closed defect (fixed)

Sugarize progress cell render

Reported by: alsroot Owned by: manuq
Priority: High Milestone:
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords: r+, olpc-test-pending
Cc: erikos, garycmartin Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

#1388 patch uses gtk.CellRendererProgress which has colors that don't fit to sugar theme.

Attachments (5)

Untitled.png (9.2 KB) - added by alsroot 13 years ago.
cellrendererprogress-current.png (4.5 KB) - added by manuq 10 years ago.
Screen grab of current state.
cellrendererprogress-new.png (11.9 KB) - added by manuq 10 years ago.
Screen grab after applying the proposed patch.
0001-Style-CellRendererProgress-3812.patch (1.2 KB) - added by manuq 10 years ago.
Proposed patch for sugar-artwork.
Screenshot of _Journal__1.png (79.9 KB) - added by erikos 10 years ago.
progress bar on download with patch applied

Download all attachments as: .zip

Change History (14)

Changed 13 years ago by alsroot

comment:1 Changed 10 years ago by manuq

  • Milestone changed from 0.86 to 1.0
  • Owner changed from benzea to manuq
  • Priority changed from Unspecified by Maintainer to High
  • Status changed from new to assigned

Also present in the new Sugar that features GTK+3. I have pushed a testcase to:

http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/83efac4c5719ed37869e07b886bea452bc6250b7

Changed 10 years ago by manuq

Screen grab of current state.

Changed 10 years ago by manuq

Screen grab after applying the proposed patch.

Changed 10 years ago by manuq

Proposed patch for sugar-artwork.

comment:2 Changed 10 years ago by manuq

Proposed patch attached. To test in Sugar:

  • open Browse, start a big download
  • go to Journal, progress should be present with the same style as the attached picture.

comment:3 Changed 10 years ago by manuq

  • Cc erikos added
  • Keywords r? added

comment:4 Changed 10 years ago by manuq

  • Cc garycmartin added

comment:5 Changed 10 years ago by manuq

  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from assigned to closed

Pushed as 6962be56 .

comment:6 follow-up: Changed 10 years ago by erikos

I was downloading an OLPC software image. The progress renderer in sugar-build and the XO is quite small. And after 2-3% at the left side there is a grey line, see screenshot.

---

Halfish unrelated: The way to cancel a download, is by erasing the entry in progress, right?

Halfish unrelated 2: Furthermore, the UI gets quite unresponsive on the XO when downloading a big file :/ We should see if we can enhance that. There is some logging going on. The writeup to disk, or some other operation takes up all of the resources.

Changed 10 years ago by erikos

progress bar on download with patch applied

comment:7 in reply to: ↑ 6 Changed 10 years ago by manuq

Replying to erikos:

I was downloading an OLPC software image. The progress renderer in sugar-build and the XO is quite small. And after 2-3% at the left side there is a grey line, see screenshot.

Great spotted, erikos. I can see in Journal listview.py code that the progress should occupy the space of the three buddies. If progress < 100, show progress cell. If progress <= 100, show the buddies cells. But indeed is not working, so I will check.

comment:8 Changed 10 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:9 Changed 10 years ago by dnarvaez

  • Milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.